Description of problem: It seems there was an incompatible change in need_config() and source_config() functions that cause ignoring of NTPPEER=no in ifcfg-* files. /sbin/dhclient-script contains: CONFIG="/etc/sysconfig/network-scripts/ifcfg-${interface}" need_config ${CONFIG} source_config >/dev/null 2>&1 But this no longer works correctly, need_config now keeps in CONFIG only the basename of the ifcfg path and source_config tries to source it in current directory which is /. Version-Release number of selected component (if applicable): initscripts-8.94-1 How reproducible: always Steps to Reproduce: 1. configure DHCP server to provide some NTP servers 2. add NTPPEER=no to ifcfg-eth0 3. disable NetworkManager (that's probably another bug) Actual results: /etc/ntp.conf modified Expected results: dhclient doesn't touch /etc/ntp.conf Additional info:
I'm assuming: diff --git a/sysconfig/network-scripts/network-functions b/sysconfig/network-script index 628cae4..c25deef 100644 --- a/sysconfig/network-scripts/network-functions +++ b/sysconfig/network-scripts/network-functions @@ -68,8 +68,8 @@ source_config () { CONFIG=${CONFIG##*/} DEVNAME=${CONFIG##ifcfg-} - . ./$CONFIG - [ -r "keys-$DEVNAME" ] && . ./keys-$DEVNAME + . /etc/sysconfig/network-scripts/$CONFIG + [ -r "keys-$DEVNAME" ] && . /etc/sysconfig/network-scripts/keys-$DEVNAME case "$TYPE" in Ethernet) DEVICETYPE="eth" fixes it for you?
Assigning it. BugZapper Team Member.
Not sure what has changed but after update to the latest rawhide it works, the current directory is /etc/sysconfig/network-scripts. Sorry for the noise.
Ok, I'm still seeing this. It doesn't show up right after start, but after first DHCP renewal. I guess the first dhclient-script run happens before dhclient chdirs to /. Adding "cd /etc/sysconfig/network-scripts" to /sbin/dhclient-script should fix it.
Is this the change we need? Index: dhclient-script =================================================================== RCS file: /cvs/pkgs/rpms/dhcp/devel/dhclient-script,v retrieving revision 1.11 diff -u -p -r1.11 dhclient-script --- dhclient-script 21 Apr 2009 01:14:15 -0000 1.11 +++ dhclient-script 21 Apr 2009 20:11:13 -0000 @@ -420,7 +420,8 @@ if [ -f /etc/sysconfig/networking/networ . /etc/sysconfig/networking/network fi -CONFIG="/etc/sysconfig/network-scripts/ifcfg-${interface}" +cd /etc/sysconfig/network-scripts +CONFIG="ifcfg-${interface}" need_config ${CONFIG} source_config >/dev/null 2>&1
Yes, that should do it.
Will be fixed in dhcp-4.1.0-19.fc11 and later.
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle. Changing version to '11'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping