Spec URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy.spec SRPM URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy-0.9.27-1.fc10.src.rpm Description: Peppy is a wxPython/Scintilla-based editor written in and extensible through Python. It attempts to provide an XEmacs-like multi-window, multi-tabbed framework with low coupling, so it's easy to add support for new types of files. This editor is an attempt to displace my dependency on XEmacs. My goal is to produce a work-alike with the feel of emacs but based on Python using the widget toolkit wxPython. I have enjoyed XEmacs for years, but my basic problem with it is this: I don't want to keep space in my brain to remember Emacs Lisp. My goal with peppy is to write an application framework that would become emacs-like in its extensibility and ability to support more than just text files, but using a modern UI toolkit for portability across platforms. RPMLINT: peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/c.c A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/c-shell_script.csh 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/cpp.cpp A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/octave.oct 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/perl.pl 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/ruby.rb 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/d.d 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/caml.ml A development file (usually source code) is located in a non-devel package. If you want to include source code in your package, be sure to create a development package. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/tcl_tk.tcl 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/korn_shell_script.ksh 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/python.python 0644 This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere. 2 packages and 0 specfiles checked; 8 errors, 3 warnings. Just templatefiles!
- Don't refer to "I" or "me" in the %description. - Add Requires: python-enchant to get the spell checking part working. rpmlint output: peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/c.c peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/c-shell_script.csh 0644 peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/cpp.cpp peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/octave.oct 0644 peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/perl.pl 0644 peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/ruby.rb 0644 peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/d.d 0644 peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/caml.ml peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/tcl_tk.tcl 0644 peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/korn_shell_script.ksh 0644 peppy.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/peppy/editra/tests/python.python 0644 2 packages and 0 specfiles checked; 8 errors, 3 warnings. - Add executable flags to the non-executable-script files, that way at the end you only get 3 devel-file-in-non-devel-package warnings that cannot be circumvented. - Package does not install. This is caused by peppy/editra/tests/octave.oct:#! /bin/octave -qf in which /bin/octave should be /usr/bin/octave. The requirement on octave is, however, quite odd. The package also requires csh and ksh due to the example files. I'd sed the shebangs out of those files, since at least octave pulls in a lot of stuff. - Add -O1 to the setup.py install arguments. - The line mkdir -p %{buildroot}/%{_datadir}/{applications,pixmaps} is not needed since both desktop-file-install and install -D create the directories. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. NEEDSFIX - You are mixing $RPM_BUILD_ROOT and %{buildroot}. This is not allowed: choose one and stick with it. MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: Optflags are used and time stamps preserved. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. NEEDSFIX - Add also PKG-INFO to %doc. MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK
ping?
There is no hurry, or?
but, i thank you for this very fast review. I'm very busy right now with other projects and so. This is in my personal schedule a not important thing. Perhaps i will find time to look in it tommorow morning.
(In reply to comment #3) > There is no hurry, or? (In reply to comment #4) > but, i thank you for this very fast review. I'm very busy right now with other > projects and so. This is in my personal schedule a not important thing. Perhaps > i will find time to look in it tommorow morning. No, no hurry; I was just wondering if you had forgot (happens to me every now and then). Take your time.
> - Add executable flags to the non-executable-script files, that way at the end > you only get 3 devel-file-in-non-devel-package warnings that cannot be > circumvented. > - Package does not install. This is caused by > peppy/editra/tests/octave.oct:#! /bin/octave -qf > in which /bin/octave should be /usr/bin/octave. The requirement on octave is, > however, quite odd. The package also requires csh and ksh due to the example > files. I'd sed the shebangs out of those files, since at least octave pulls in > a lot of stuff. removing shebangs of all files should do the trick to clear both. -- build.log -- + sed -e 1d -i peppy/editra/tests/c-shell_script.csh peppy/editra/tests/octave.oct peppy/editra/tests/perl.pl peppy/editra/tests/ruby.rb peppy/editra/tests/d.d peppy/editra/tests/tcl_tk.tcl peppy/editra/tests/korn_shell_script.ksh peppy/editra/tests/python.python > - Add -O1 to the setup.py install arguments. -- build.log -- + python setup.py install -01 --skip-build --root /builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386 /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'zip_safe' warnings.warn(msg) /usr/lib/python2.6/distutils/dist.py:266: UserWarning: Unknown distribution option: 'windows' warnings.warn(msg) packages = ['peppy', 'peppy.yapsy', 'peppy.editra', 'peppy.editra.eclib', 'peppy.editra.syntax', 'peppy.i18n', 'peppy.lib', 'peppy.plugins', 'peppy.vfs', 'peppy.vfs.itools', 'peppy.vfs.itools.uri', 'peppy.vfs.itools.vfs', 'peppy.actions', 'peppy.hsi'] usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] or: setup.py --help [cmd1 cmd2 ...] or: setup.py --help-commands or: setup.py cmd --help error: option -0 not recognized > - The line > mkdir -p %{buildroot}/%{_datadir}/{applications,pixmaps} > is not needed since both desktop-file-install and install -D create the > directories. -- build.log -- + desktop-file-install --dir=/builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/applications/ /builddir/build/SOURCES/peppy.desktop + install -Dpm0644 /builddir/build/SOURCES/peppy.png /builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/ install: target `/builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/' is not a directory: No such file or directory > MUST: The spec file for the package is legible and macros are used > consistently. NEEDSFIX > - You are mixing $RPM_BUILD_ROOT and %{buildroot}. This is not allowed: choose > one and stick with it. oops > MUST: All relevant items are included in %doc. Items in %doc do not affect > runtime of application. NEEDSFIX > - Add also PKG-INFO to %doc. k > - Don't refer to "I" or "me" in the %description. I removed this part completely > - Add Requires: python-enchant to get the spell checking part working. spell checking is a damn bitch. I hate it. But okay, for the most users this is an important "feature". Spec URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy.spec SRPM URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy-0.9.27-2.fc11.src.rpm
(In reply to comment #6) > > - Add -O1 to the setup.py install arguments. > error: option -0 not recognized -O1 not -01. > > > > - The line > > mkdir -p %{buildroot}/%{_datadir}/{applications,pixmaps} > > is not needed since both desktop-file-install and install -D create the > > directories. > + install -Dpm0644 /builddir/build/SOURCES/peppy.png > /builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/ > install: target > `/builddir/build/BUILDROOT/peppy-0.9.27-1.fc11.i386//usr/share/pixmaps/' is not > a directory: No such file or directory If you use install -Dpm0644 %{SOURCE2} %{buildroot}/%{_datadir}/pixmaps/%{name}.png it works. ** Doesn't build: + sed -e -i 1d peppy/editra/tests/c-shell_script.csh peppy/editra/tests/octave.oct peppy/editra/ tests/perl.pl peppy/editra/tests/ruby.rb peppy/editra/tests/d.d peppy/editra/tests/tcl_tk.tcl pe ppy/editra/tests/korn_shell_script.ksh peppy/editra/tests/python.python sed: -e expression #1, char 1: unknown command: `-'
(In reply to comment #7) > -O1 not -01. aah, okay :-) > If you use > install -Dpm0644 %{SOURCE2} %{buildroot}/%{_datadir}/pixmaps/%{name}.png > it works. okay. I learned a new thing :-) > Doesn't build: > + sed -e -i 1d peppy/editra/tests/c-shell_script.csh > peppy/editra/tests/octave.oct peppy/editra/ > tests/perl.pl peppy/editra/tests/ruby.rb peppy/editra/tests/d.d > peppy/editra/tests/tcl_tk.tcl pe > ppy/editra/tests/korn_shell_script.ksh peppy/editra/tests/python.python > sed: -e expression #1, char 1: unknown command: `-' aaah sed -e '1d' -i instead of sed -e -i '1d' i built it with sed -e '1d' -i, don't know why i changed it. this was very stupid, sorry! Spec URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy.spec SRPM URL: http://cassmodiah.fedorapeople.org/peppy-0.9.27/peppy-0.9.27-3.fc11.src.rpm
rpmlint output: peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/c.c peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/cpp.cpp peppy.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.5/site-packages/peppy/editra/tests/caml.ml 2 packages and 0 specfiles checked; 0 errors, 3 warnings. These are OK, requires are sane too. The package has been APPROVED
Thank you Jussi New Package CVS Request ======================= Package Name: peppy Short Description: Editor written in python Owners: cassmodiah Branches: F-11 InitialCC:
No F-10??
New Package CVS Request ======================= Package Name: peppy Short Description: Editor written in python Owners: cassmodiah Branches: F-11 F-10 InitialCC:
cvs done.
peppy-0.9.27-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/peppy-0.9.27-3.fc11
peppy-0.9.27-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/peppy-0.9.27-3.fc10
peppy-0.9.27-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update peppy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-4693
peppy-0.9.27-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update peppy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-4846
On F-10, after installation of peppy-0.9.27-3.fc10.noarch $ peppy Traceback (most recent call last): File "/usr/bin/peppy", line 13, in <module> import peppy.main File "/usr/lib/python2.5/site-packages/peppy/main.py", line 10, in <module> import wx ImportError: No module named wx This is due to a missing Requires: wxPython Jussi: when doing a review, it's always worth installing a package into a chroot to see if it runs properly and pulls in all the correct packages and no more.
Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to update the package.
(In reply to comment #19) > Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to > update the package. $ HEAD http://peppy.flipturn.org/archive/peppy-0.9.86.tar.bz2 reports Last-Modified: Thu, 14 May 2009 18:19:31 GMT so the new version has been released only a couple of days ago. (In reply to comment #18) > On F-10, after installation of peppy-0.9.27-3.fc10.noarch > > $ peppy > Traceback (most recent call last): > File "/usr/bin/peppy", line 13, in <module> > import peppy.main > File "/usr/lib/python2.5/site-packages/peppy/main.py", line 10, in <module> > import wx > ImportError: No module named wx > > This is due to a missing Requires: wxPython ?? peppy-0.9.27-3 already Requires: wxPython. For me it works fine.
# yum --enablerepo=updates-testing install peppy Loaded plugins: fastestmirror, refresh-packagekit Loading mirror speeds from cached hostfile * updates-testing: ftp.esat.net * rpmfusion-nonfree-updates: fr2.rpmfind.net * fedora: ftp.esat.net * rpmfusion-free-updates: fr2.rpmfind.net * rpmfusion-free: fr2.rpmfind.net * updates: ftp.esat.net * rpmfusion-nonfree: fr2.rpmfind.net updates-testing | 3.0 kB 00:00 updates-testing/primary_db | 510 kB 00:01 Setting up Install Process Parsing package install arguments Resolving Dependencies --> Running transaction check ---> Package peppy.noarch 0:0.9.27-3.fc10 set to be updated --> Processing Dependency: python-enchant for package: peppy --> Running transaction check ---> Package python-enchant.x86_64 0:1.3.1-2.fc9 set to be updated --> Finished Dependency Resolution Dependencies Resolved ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: peppy noarch 0.9.27-3.fc10 updates-testing 1.8 M Installing for dependencies: python-enchant x86_64 1.3.1-2.fc9 fedora 107 k Transaction Summary ================================================================================ Install 2 Package(s) Update 0 Package(s) Remove 0 Package(s) Total download size: 1.9 M Is this ok [y/N]: y Downloading Packages: (1/2): python-enchant-1.3.1-2.fc9.x86_64.rpm | 107 kB 00:00 (2/2): peppy-0.9.27-3.fc10.noarch.rpm | 1.8 MB 00:02 -------------------------------------------------------------------------------- Total 655 kB/s | 1.9 MB 00:02 Running rpm_check_debug Running Transaction Test Finished Transaction Test Transaction Test Succeeded Running Transaction Installing : python-enchant 1/2 Installing : peppy 2/2 Installed: peppy.noarch 0:0.9.27-3.fc10 Dependency Installed: python-enchant.x86_64 0:1.3.1-2.fc9 Complete! [root@m1210 jgu]# exit exit [jgu@m1210 ~]$ [jgu@m1210 ~]$ [jgu@m1210 ~]$ peppy Traceback (most recent call last): File "/usr/bin/peppy", line 13, in <module> import peppy.main File "/usr/lib/python2.5/site-packages/peppy/main.py", line 10, in <module> import wx ImportError: No module named wx So, for whatever reason, it doesn't pull in wxPython. $ rpm -q --requires peppy /usr/bin/env /usr/bin/python python(abi) = 2.5 python-enchant rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
(In reply to comment #20) > (In reply to comment #19) > > Also, there's a newer upstream version peppy-0.9.86.tar.bz2 - it'd be nice to > > update the package. > > $ HEAD http://peppy.flipturn.org/archive/peppy-0.9.86.tar.bz2 > reports > Last-Modified: Thu, 14 May 2009 18:19:31 GMT > > so the new version has been released only a couple of days ago. > Yes, sure, was only mentioning it in passing for information, wasn't a criticism.
peppy-0.9.86-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/peppy-0.9.86-1.fc11
peppy-0.9.86-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/peppy-0.9.86-1.fc10
(In reply to comment #21) > So, for whatever reason, it doesn't pull in wxPython. > > $ rpm -q --requires peppy > /usr/bin/env > /usr/bin/python > python(abi) = 2.5 > python-enchant > rpmlib(CompressedFileNames) <= 3.0.4-1 > rpmlib(PartialHardlinkSets) <= 4.0.4-1 > rpmlib(PayloadFilesHavePrefix) <= 4.0-1 True. This is quite odd. Anyway, the rpm of the new version requires wxPython, so it should work as expected.
Can confirm that packages fixes the Reequires: # rpm -Uvh peppy-0.9.86-1.fc10.noarch.rpm Preparing... ########################################### [100%] 1:peppy ########################################### [100%] [root@m1210 ~]# rpm -q --requires peppy /usr/bin/env /usr/bin/python python(abi) = 2.5 python-enchant rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PartialHardlinkSets) <= 4.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 wxPython Thanks much.
peppy-0.9.86-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update peppy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-5072
peppy-0.9.86-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update peppy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-5144
peppy-0.9.86-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
peppy-0.9.86-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.