Spec URL: http://www.bachelot.org/fedora/SPECS/perl-MIME-EncWords.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-MIME-EncWords-1.010.101-1.fc10.src.rpm Description: perl module to deal with RFC 2047 encoded words.
Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1334537 + rpmlint output for SRPM and for RPM. perl-MIME-EncWords.noarch: E: useless-provides perl(MIME::EncWords) => This package provides 2 times the same capacity. It should only provide it + source files match upstream url 2009449d0af39275d45e45a4afcaf58f MIME-EncWords-1.010.101.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=74, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.14 cusr 0.02 csys = 0.20 CPU) + Package perl-MIME-EncWords-1.010.101-1.fc12.noarch => Provides: perl(MIME::EncWords) perl(MIME::EncWords) = 1.010.101 Requires: perl >= 0:5.005 perl(Exporter) perl(strict) perl(vars) + Not a GUI application suggestions: 1) make sure to remove unnecessary provides perl(MIME::EncWords) 2) you don't need Requires: perl(MIME::Charset) >= 1.006.2 APPROVED.
I also think description you included should have changed to This package is aimed to be another implementation of MIME::Words so that it will achieve more exact conformance with RFC 2047 (former RFC 1522) specifications. Additionally, it contains some improvements. Following synopsis and descriptions are inherited from its inspirer, then added descriptions on improvements (**) or changes and clarifications (*).*
Thanks for the review. I will fix the point outlined above before importing. New Package CVS Request ======================= Package Name: perl-MIME-EncWords Short Description: perl module to deal with RFC 2047 encoded words Owners: xavierb Branches: F-9 F-10 F-11 EL-5 InitialCC: perl-sig
Updated package : Spec URL: http://www.bachelot.org/fedora/SPECS/perl-MIME-EncWords.spec SRPM URL: http://www.bachelot.org/fedora/SRPMS/perl-MIME-EncWords-1.010.101-2.fc10.src.rpm
cvs done.
perl-MIME-EncWords-1.010.101-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-MIME-EncWords-1.010.101-2.fc10
perl-MIME-EncWords-1.010.101-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-MIME-EncWords-1.010.101-2.fc11
perl-MIME-EncWords-1.010.101-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/perl-MIME-EncWords-1.010.101-2.fc9
perl-MIME-EncWords-1.010.101-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-MIME-EncWords-1.010.101-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
perl-MIME-EncWords-1.010.101-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.