Spec URL: http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode-0.11-1.fc11.src.rpm Description: It aims to change the code to be better (to be worse if you want). http://koji.fedoraproject.org/koji/taskinfo?taskID=1322216
Updating line-endings (such as via dos2unix) is generally done in %prep... perl(Test::Pod) also needs to be included as a BR. Do the two updates above and I'll approve :) koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1322216 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz 0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Acme-PlayCode-0.11-1.fc10.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Acme-PlayCode-0.11-1.fc10.src.rpm ====> requires for perl-Acme-PlayCode-0.11-1.fc10.src.rpm dos2unix perl(List::MoreUtils) perl(Module::Build) perl(Moose) >= 0.57 perl(MooseX::Object::Pluggable) >= 0.0008 perl(Path::Class) >= 0.16 perl(PPI) >= 1.201 perl(Test::More) =====> perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm perl(Acme::PlayCode) = 0.11 perl-Acme-PlayCode = 0.11-1.fc10 perl(Acme::PlayCode::Plugin::Averything) = 0.10 perl(Acme::PlayCode::Plugin::DoubleToSingle) = 0.10 perl(Acme::PlayCode::Plugin::ExchangeCondition) = 0.10 perl(Acme::PlayCode::Plugin::NumberPlus) = 0.11 perl(Acme::PlayCode::Plugin::PrintComma) = 0.10 ====> requires for perl-Acme-PlayCode-0.11-1.fc10.noarch.rpm perl(Data::Dumper) perl(List::MoreUtils) perl(:MODULE_COMPAT_5.10.0) perl(Moose) perl(Moose::Role) perl(Path::Class) perl(PPI) perl(PPI::Token::Comment) perl(vars)
Updated srpm http://mmaslano.fedorapeople.org/review/perl-Acme-PlayCode-0.11-2.fc11.src.rpm I think dos2unix in prep is not needed but I moved it for you.
Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=1334190
Generally speaking, dos2unix (or the ever popular "sed -e 's/\r//'") doesn't strictly belong in %prep, but it fits far better in there than it does in %build. Stripping dos-like EOL characters from source is as much preparing it as is patching it, or removing errant execute bits, etc. Absent a very compelling reason, we wouldn't include a %patch in %build, would we? koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1334190 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz 0034e6c7961d2f9ed8b5e6ad60ac7333941d73d9 Acme-PlayCode-0.11.tar.gz.srpm Final provides / requires are sane: 0 packages and 1 specfiles checked; 0 errors, 0 warnings. =====> perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm perl(Acme::PlayCode) = 0.11 perl-Acme-PlayCode = 0.11-2.fc12 perl(Acme::PlayCode::Plugin::Averything) = 0.10 perl(Acme::PlayCode::Plugin::DoubleToSingle) = 0.10 perl(Acme::PlayCode::Plugin::ExchangeCondition) = 0.10 perl(Acme::PlayCode::Plugin::NumberPlus) = 0.11 perl(Acme::PlayCode::Plugin::PrintComma) = 0.10 ====> requires for perl-Acme-PlayCode-0.11-2.fc12.noarch.rpm perl(Data::Dumper) perl(List::MoreUtils) perl(:MODULE_COMPAT_5.10.0) perl(Moose) perl(Moose::Role) perl(Path::Class) perl(PPI) perl(PPI::Token::Comment) perl(vars) =====> perl-Acme-PlayCode-0.11-2.fc12.src.rpm <===== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides for perl-Acme-PlayCode-0.11-2.fc12.src.rpm ====> requires for perl-Acme-PlayCode-0.11-2.fc12.src.rpm dos2unix perl(List::MoreUtils) perl(Module::Build) perl(Moose) >= 0.57 perl(MooseX::Object::Pluggable) >= 0.0008 perl(Path::Class) >= 0.16 perl(PPI) >= 1.201 perl(Test::More) perl(Test::Pod) APPROVED
The position of dos2unix is arguable. In different review I was told to use it in prep because it prepare the source :) Thank you for your review. I own you some.
New Package CVS Request ======================= Package Name: perl-Acme-PlayCode Short Description: Perl module for enhancement of code Owners: mmaslano Branches: F-11 InitialCC: perl-sig
cvs done.