Bug 498198 - Review Request: perl-WebService-Validator-HTML-W3C - Access the W3Cs online HTML validator
Review Request: perl-WebService-Validator-HTML-W3C - Access the W3Cs online H...
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-04-29 08:27 EDT by Marcela Mašláňová
Modified: 2009-04-30 01:49 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-04-30 01:49:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Marcela Mašláňová 2009-04-29 08:27:33 EDT
Spec URL: http://mmaslano.fedorapeople.org/review/perl-WebService-Validator-HTML-W3C.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-WebService-Validator-HTML-W3C-0.24-1.fc11.src.rpm
Description: 
WebService::Validator::HTML::W3C provides access to the W3C's online Markup
validator. As well as reporting on whether a page is valid it also provides
access to a detailed list of the errors and where in the validated document
they occur.
Comment 1 Parag AN(पराग) 2009-04-29 12:00:01 EDT
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328794
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7c58ebb1df29fdc0b88474217c064f10  WebService-Validator-HTML-W3C-0.24.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
 Files=16, Tests=82,  1 wallclock secs ( 0.06 usr  0.02 sys +  1.05 cusr  0.14 csys =  1.27 CPU)
+ Package  perl-WebService-Validator-HTML-W3C-0.24-1.fc12.noarch=>
Provides: perl(WebService::Validator::HTML::W3C) = 0.24 perl(WebService::Validator::HTML::W3C::Error) perl(WebService::Validator::HTML::W3C::Warning)
Requires: perl(HTTP::Request::Common) perl(LWP::UserAgent) perl(URI::Escape) perl(WebService::Validator::HTML::W3C::Error) perl(WebService::Validator::HTML::W3C::Warning) perl(base) perl(strict)


APPROVED
Comment 2 Marcela Mašláňová 2009-04-29 12:22:49 EDT
New Package CVS Request
=======================
Package Name: perl-WebService-Validator-HTML-W3C
Short Description: Access the W3Cs online HTML validator
Owners: mmaslano
Branches: F-11
InitialCC: perl-sig
Comment 3 Kevin Fenzi 2009-04-30 01:05:43 EDT
cvs done.

Note You need to log in before you can comment on or make changes to this bug.