Spec URL: http://tmp.sereinity.homelinux.org/rpm/dynamic-wallpaper.spec SRPM URL: http://tmp.sereinity.homelinux.org/rpm/dynamic-wallpaper-0.3-1.fc10.src.rpm Description: Dynamic wallpaper is based on weather-wallpaper and generates svg wallpaper based on current weather, season, time of day and others. It supports themes.
Several notes: ! Mock fails: error: File not found by glob: /builddir/build/BUILDROOT/dynamic-wallpaper-0.3-1.fc11.x86_64/usr/bin/motor.py? Try change to: %exclude %{_bindir}/motor.pyc - Add this line at %prep to preserve time stamps: sed -i 's|install |install -p |' Makefile - The new version is on upstream, please update. - If not necessary, delete commented make line from %build ? If you sponsored packager, I can make review...
I haven't this problem with mock, what's your fedora's version ? mock works fine in my F10. I've put 2 %exclude line to fix the problem. new links : SPEC : http://tmp.sereinity.homelinux.org/rpm/dynamic-wallpaper.spec SRPM : http://tmp.sereinity.homelinux.org/rpm/dynamic-wallpaper-0.3.1-1.fc10.src.rpm
Note : I'm already sponsored, I just need review.
OK, I assigned. 1. Koji build on dist-f10 passed, but dist-f11 failed! See: http://koji.fedoraproject.org/koji/taskinfo?taskID=1382595 2. At Changelog, the newest instances must go upper then old ones, so change this.
Ok, I see, it will be better to have to SPEC file : one with %exclude line, the other without. Sorry for the mistake in changelog.
(files are updated)
- I thin that you do not need this: ============================================================= update-mime-database %{_kde4_datadir}/mime &> /dev/null || : ============================================================= This is neded only if application drops an XML file in %{_datadir}/mime/packages. Please, can you explain this: ============================================= unset QTINC QTLIB QTPATH_LRELEASE QMAKESPEC export QT4DIR=%{_libdir}/qt4 export QTDIR=$QT4DIR PATH=$QT4DIR/bin:$PATH ; export PATH ============================================= Do we need this?
Huh, forget last message, it isn't from this story ;) BTW, your spec seem to be OK, please change to this: %if %{?fedora} < 11 %exclude %{_bindir}/motor.py? %endif I
Last notes... - License is LGPLv2+ in COPYING file, but in python code stands GPLv2. Can you clarify?
No I can't, while it's not blocking (both are accepted in fedora). But I have send an email to the author to clarify the situation.
(In reply to comment #10) > No I can't, while it's not blocking (both are accepted in fedora). Yes, I know. But I want to know which one is relevant.
The response was : > Obviously I missed that. Because some of the source files are not written by me I can't change their license, so I guess that the more conservative stays - GPLv2. So I think we keep GPLv2.
Good. So, can you patch COPYING file with the right license information (GPLv2)?
Updated
Good! Please, one more (little) thing: - Comment this patch file (place comment line before Patch0: %{name}-copying.patch)
Ok, done.
Now, I APPROVED.
New Package CVS Request ======================= Package Name: dynamic-wallpaper Short Description: Generates svg wallpaper based on current weather, season and others Owners: sereinit Branches: F-9 F-10 F-11 InitialCC: none
CVS done.