Red Hat Bugzilla – Bug 498476
widgets.inc produces E_NOTICE level errors
Last modified: 2009-08-05 14:43:32 EDT
Created attachment 341957 [details]
eliminates E_NOTICE errors from widgets.inc
The following file creates PHP E_NOTICE level errors:
The attached patch solves this (at least the one that people reported in IRC). This patch is safe because side_nav_traverse() also checks for empty(), so a value of 0 has no use here.
Another option is to hide E_NOTICE level errors but I don't feel that's the proper route...
I fixed this in my local checkout and it looks fine. However, I'm not a PHP programmer so cannot independently varify the quality of the fix compared to what is there already.
Philip -- it's more a matter of making sure we're not introducing a worse problem. Can we find someone from #fedora-admin to verify the fix and I'll apply it?
I can confirm that this is the correct way to fix this issue.
OK, thanks Patrick.
The fix is in CVS and tagged LIVE. It should get grabbed in the next rebuild of the site, which IIRC is done 4 times a day.
Thanks for the catch and the patch!
Tickets move to docs-request so the fedora-websites component can be removed per request from Ricky.