Spec URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Cache.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Cache-0.08-1.fc12.src.rpm Description: This plugin gives you access to a variety of systems for caching data. It allows you to use a very simple configuration API, while maintaining the possibility of flexibility when you need it later. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1333666 *rt-0.09
Spec URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Cache.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Catalyst-Plugin-Cache-0.08-2.fc12.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1333703
Review: + package builds in mock (rawhide i586). lkoji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1333703 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1bd5edb5df1530fb71c4c3c5ba22916a Catalyst-Plugin-Cache-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=6, Tests=60, 2 wallclock secs ( 0.07 usr 0.02 sys + 1.63 cusr 0.17 csys = 1.89 CPU) + Package perl-Catalyst-Plugin-Cache-0.08-2.fc12.noarch-> Provides: perl(Catalyst::Plugin::Cache) = 0.08 perl(Catalyst::Plugin::Cache::Backend) perl(Catalyst::Plugin::Cache::Backend::Memory) perl(Catalyst::Plugin::Cache::Choose::KeyRegexes) perl(Catalyst::Plugin::Cache::Curried) perl(Catalyst::Plugin::Cache::Store::Memory) Requires: perl(Carp) perl(Catalyst::Plugin::Cache::Backend::Memory) perl(Catalyst::Plugin::Cache::Curried) perl(Catalyst::Utils) perl(MRO::Compat) perl(Scalar::Util) perl(Storable) perl(base) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-Cache Short Description: Flexible caching support for Catalyst Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Catalyst-Plugin-Cache-0.08-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Cache-0.08-2.fc11
perl-Catalyst-Plugin-Cache-0.08-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Catalyst-Plugin-Cache-0.08-2.fc10
Thanks for the review! :-)
perl-Catalyst-Plugin-Cache-0.08-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
perl-Catalyst-Plugin-Cache-0.08-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.