Bug 501550 - virtio console device has lame PCI class info
virtio console device has lame PCI class info
Product: Fedora
Classification: Fedora
Component: qemu (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Justin M. Forbes
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2009-05-19 13:38 EDT by Adam Jackson
Modified: 2010-03-11 14:23 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-03-11 14:23:29 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
qemu-0.10.4-virtio-console-pci-class.patch (1.23 KB, patch)
2009-05-19 13:39 EDT, Adam Jackson
no flags Details | Diff

  None (edit)
Description Adam Jackson 2009-05-19 13:38:50 EDT
Description of problem:

00:05.0 Unclassified device [00ff]: Qumranet, Inc. Virtio console
        Subsystem: Qumranet, Inc. Device 0003
        Physical Slot: 5
        Flags: fast devsel, IRQ 10
        I/O ports at c220 [size=32]
        Kernel driver in use: virtio-pci
        Kernel modules: virtio_pci

While this is valid, many versions of X will get confused by it.  Class major number of 0 gets treated as a possibly prehistoric VGA device, and then the autoconfig logic gets confused trying to figure out whether the virtio console or the pv vga device are the real VGA.

Worked around in the X server in F11, but we should really set a proper class ID.  0x0780 (serial / other) seems most appropriate.  Attached patch does this.  Shouldn't require any kernel changes, the modalias for virtio looks like:

alias:          pci:v00001AF4d*sv*sd*bc*sc*i*

so won't care what the base class or subclass are.

Version-Release number of selected component (if applicable):

Comment 1 Adam Jackson 2009-05-19 13:39:31 EDT
Created attachment 344655 [details]
Comment 2 Mark McLoughlin 2009-05-22 13:16:16 EDT
Interesting that qemu-kvm actually changed from qemu's PCI_CLASS_DISPLAY_OTHER:


I've posted a re-based version of your patch to qemu-devel:

  Subject: [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER
Comment 3 Bug Zapper 2009-06-09 12:07:18 EDT
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
Comment 4 Fedora Admin XMLRPC Client 2010-03-09 11:54:04 EST
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 5 Fedora Admin XMLRPC Client 2010-03-09 12:17:36 EST
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 6 Justin M. Forbes 2010-03-11 14:23:29 EST
This should be fixed in qemu 0.12.x

Note You need to log in before you can comment on or make changes to this bug.