Red Hat Bugzilla – Bug 502352
Review Request: php-markdown - Markdown implementation in PHP
Last modified: 2013-03-23 14:17:30 EDT
This is a PHP implementation of John Gruber's Markdown. This is a
Python implementation of John Gruber's Markdown. It is almost
completely compliant with the reference implementation.
It is required for laconica.
Few items to check:
* rpmlint is not clean:
php-markdown.src:20: W: setup-not-quiet
php-markdown.src: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line 1)
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
add -q to the %setup line and file the tab/space issue
* php and unzip are not needed to build, php can stay as a Require: tough
* you may consider using the "install" command instead of mkdir+cp
the last one is not a "must".
Fix the first two items and I think I can approve the package
* package name follows naming guidelines
* License (BSD) is good and matches actual one
* License text is present and correctly packaged
* sources matches upstream ( MD5 0111093efcb81e455e7bbd959d4cff54 )
* rpmlint is silent
* build fine in mock for F10
just a couple of final remarks.
Since you included the non numeric part in the version field, please pay attention to future upgrades and use rpmdev-vercmp to check if the upgrade path is correct.
There are worpress refernces in the code. I don't know if this is included/used by default in WP, but if this is the case the WP maintainer should be requiring this package instead. It would be nice if you discuss with him about the issue
PHP Markdown can work as a optional plug-in for Wordpress. I will inform maintainer.
New Package CVS Request
Package Name: php-markdown
Short Description: Markdown implementation in PHP
Branches: F-9 F-10 F-11
Cvsextras Commits: yes
php-markdown-1.0.1m-2.fc9 has been submitted as an update for Fedora 9.
php-markdown-1.0.1m-2.fc10 has been submitted as an update for Fedora 10.
php-markdown-1.0.1m-2.fc11 has been submitted as an update for Fedora 11.
php-markdown-1.0.1m-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.
php-markdown-1.0.1m-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
php-markdown-1.0.1m-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
Remi, I need an EL-6 branch for php-markdown. I'm willing to maintain it if you'd rather not. Also, I see it's orphaned in f18 and f17, do you want those or should I pick it up?
Package Change Request
Package Name: php-markdown
New Branches: el5 el6
Git done (by process-git-requests).
php-markdown-1.0.1p-1.el6 has been submitted as an update for Fedora EPEL 6.
php-markdown-1.0.1p-1.el5 has been submitted as an update for Fedora EPEL 5.
php-markdown-1.0.1p-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
php-markdown-1.0.1p-1.el5 has been pushed to the Fedora EPEL 5 stable repository.