Bug 502896 - virtinst should support kvm-img and qemu-img
Summary: virtinst should support kvm-img and qemu-img
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virtinst
Version: unspecified
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Daniel Berrangé
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-27 16:36 UTC by Doug Goldstein
Modified: 2010-03-16 17:20 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-09 16:28:08 UTC
Embargoed:


Attachments (Terms of Use)
virtinst-0.400.3-kvm-img.patch (1.03 KB, patch)
2009-05-27 16:36 UTC, Doug Goldstein
no flags Details | Diff

Description Doug Goldstein 2009-05-27 16:36:58 UTC
Created attachment 345648 [details]
virtinst-0.400.3-kvm-img.patch

Description of problem:

virtinst relies on qemu-img to exist at runtime. Several distros install all of kvm with the utilities prefixed as kvm- so that there's not a file collision when installing qemu.

Attached is a patch that should make it work in those cases.

Comment 1 Cole Robinson 2009-05-27 16:42:05 UTC
Huh, good to know.

I would also recommend you file a bug against libvirt for the same issue: libvirt storage APIs use qemu-img for all non-raw provisioning. It should be as simple as changing the configure script to look for kvm-img as well.

Comment 2 Doug Goldstein 2009-05-27 17:19:50 UTC
Will do Cole. I'm actually in the process of writing the patch for libvirt. It's a little bit more involved since I'm refactoring some code to support a few of the /* XXX: Need to support this when qemu-img does */ sections because kvm-img actually supports those features.

Comment 3 Cole Robinson 2009-06-09 16:28:08 UTC
Thanks, pushed now:

http://hg.et.redhat.com/cgi-bin/hg-virt.cgi/applications/virtinst--devel/rev/89c9f3ece3fb

Closing as UPSTREAM.


Note You need to log in before you can comment on or make changes to this bug.