Bug 503021 - Review Request: pony - a simple image manager
Summary: Review Request: pony - a simple image manager
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2009-05-28 10:43 UTC by kushaldas@gmail.com
Modified: 2009-05-29 20:23 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-05-29 20:23:46 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mmaslano: fedora-review+
tibbs: fedora-cvs+

Attachments (Terms of Use)

Description kushaldas@gmail.com 2009-05-28 10:43:03 UTC
Spec URL: http://kushal.fedorapeople.org/packages/pony.spec
SRPM URL: http://kushal.fedorapeople.org/packages/pony-0.1-1.fc11.src.rpm
Description: Pony is a simple KDE based image manager.

Comment 1 Marcela Mašláňová 2009-05-28 11:40:40 UTC
? Rpmlint must be run on every package.
    pony.noarch: W: dangling-symlink /usr/share/doc/HTML/en/pony/common /usr/share/doc/HTML/en/common

OK The package must be named according to the Package Naming Guidelines.
    There exist some sw but nothing exactly named pony:

OK The spec file name must match the base package %{name}.
OK The package must meet the Packaging Guidelines.
OK The package must be licensed with a Fedora approved license.
OK The License field in the package spec file must match the actual license.
OK If (and only if) the source package includes the text of the license(s) in its own file.
OK The spec file must be written in American English.
OK The spec file for the package MUST be legible.
OK The sources used to build the package must match the upstream source.
OK The package MUST successfully compile.
OK Correct BuildRequires.
OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
OK Shared library files (not just symlinks) must call ldconfig in %post and %postun.
OK Relocatable package must state this fact in the request for review.
OK A package must own all directories that it creates.
OK A package must not contain any duplicate files in the %files listing.
OK Permissions on files must be set properly.
OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK Each package must consistently use macros.
OK The package must contain code, or permissable content.
OK Large documentation files must go in a -doc subpackage.
OK If a package includes something as %doc, it must not affect the runtime of the application.
OK Header files must be in a -devel package.
OK Static libraries must be in a -static package.
OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel.
OK In the vast majority of cases, devel packages must require the base package.
OK Packages must NOT contain any .la libtool archives.
OK Packages containing GUI applications must include a %{name}.desktop file.
OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT)

Comment 2 Marcela Mašláňová 2009-05-28 11:53:13 UTC
Wow, it's cool. Please add your source to correct place, which would be somewhere at https://fedorahosted.org/releases/...
I'm unsure about the rest of path but the pros are that others can download from here by wget.

Comment 3 kushaldas@gmail.com 2009-05-28 12:31:38 UTC
Sorry for that stupid mistake on source url.

Spec URL: http://kushal.fedorapeople.org/packages/pony.spec
SRPM URL: http://kushal.fedorapeople.org/packages/pony-0.1-2.fc11.src.rpm

Comment 4 Marcela Mašláňová 2009-05-28 12:36:23 UTC
No problem, but what about the rpmlint?
pony.noarch: W: dangling-symlink /usr/share/doc/HTML/en/pony/common

Comment 5 kushaldas@gmail.com 2009-05-28 12:44:10 UTC
/usr/share/doc/HTML/en/common comes from KDE itself (I guess kdelibs or something). Last night from #fedora-kde i learnt:

This is a bug in the KDE CMake stuff.
All the KDE packages have broken symlinks like that.

Comment 6 Marcela Mašláňová 2009-05-28 12:58:47 UTC
Ok, this explanation is enough.


Comment 7 kushaldas@gmail.com 2009-05-28 13:02:59 UTC
New Package CVS Request
Package Name: pony
Short Description: Pony is a simple image manager 
Owners: kushal
Branches: F-11 F-10
InitialCC: kushal

Comment 8 Jason Tibbitts 2009-05-28 16:02:11 UTC
CVS done.

Comment 9 Wilmer Jaramillo M. 2009-05-29 19:32:12 UTC
This should be the faster review approved.

Comment 10 kushaldas@gmail.com 2009-05-29 20:23:46 UTC
cvs imported

Note You need to log in before you can comment on or make changes to this bug.