Bug 503426 - bfd attempts to chmod +x !S_ISREG() output files
Summary: bfd attempts to chmod +x !S_ISREG() output files
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: binutils
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-31 23:40 UTC by Eric Paris
Modified: 2009-06-11 15:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-11 15:30:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to make bfd only add +x to regular output files. (722 bytes, patch)
2009-05-31 23:40 UTC, Eric Paris
no flags Details | Diff

Description Eric Paris 2009-05-31 23:40:32 UTC
Created attachment 346036 [details]
Patch to make bfd only add +x to regular output files.

When running as a user with restrictive SELinux permissions I found that the kernel build process passes -o /dev/null to the linker in a number of places, this in turn caused the attempt to add +x to /dev/null.

This patch causes the linker to only attempt to add the execute bit on S_ISREG output files, as execute permissions on chr,blk,etc doesn't make much sense.

Comment 1 Bug Zapper 2009-06-09 16:53:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 11 development cycle.
Changing version to '11'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Nick Clifton 2009-06-11 15:30:05 UTC
Hi Eric,

  Thanks for reporting this bug and providing a fix for it as well.  I apologise for taking so long to respond to it.  

  Your patch is fine and I have added it to the rawhide binutils package (binutils-2.19.51.0.2-21.fc12).

  Cheers
   Nick


Note You need to log in before you can comment on or make changes to this bug.