Bug 503742 - Review Request: libssh - A library implementing the SSH2 protocol (0xbadc0de version)
Summary: Review Request: libssh - A library implementing the SSH2 protocol (0xbadc0de ...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matěj Cepl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 503753 503754 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-06-02 13:42 UTC by Jan F. Chadima
Modified: 2018-04-11 07:58 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-06-04 14:21:24 UTC
Type: ---
Embargoed:
mcepl: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jan F. Chadima 2009-06-02 13:42:40 UTC
Spec URL: http://www.benhur.prf.cuni.cz/medved-7/wydobitki/fedora/libssh/libssh.spec
SRPM URL: http://www.benhur.prf.cuni.cz/medved-7/wydobitki/fedora/libssh/libssh-0.2-1.fc11.src.rpm
Description: 
The SSH library with
-Full C library functions for manipulating a client-side SSH connection                                                                     
-Fully configurable sessions                                                                                                                
-Support for AES-128,AES-192,AES-256,blowfish, in cbc mode                                                                                  
-use multiple SSH connections in a same process, at same time.                                                                              
-usable SFTP implementation                                                                                                                 
-Public key and password authentication

Comment 1 Peter Lemenkov 2009-06-02 14:00:35 UTC
What's the difference between this library and that one:
http://cvs.fedoraproject.org/viewvc/rpms/libssh2/

?

Comment 2 Matěj Cepl 2009-06-02 14:36:38 UTC
*** Bug 503754 has been marked as a duplicate of this bug. ***

Comment 3 Jan F. Chadima 2009-06-02 14:37:04 UTC
The libssh has different API.

Comment 4 Matěj Cepl 2009-06-02 14:57:11 UTC
+ GOOD: rpmlint is silent on both source and binary package.
+ GOOD: The package is named according to the Package Naming Guidelines .
+ GOOD: The spec file name matches the base package %{name}, in the format
  %{name}.spec.
+ GOOD: The package meets the Packaging Guidelines .
+ GOOD: The package is licensed with a Fedora approved license and meet the
Licensing Guidelines.
+ GOOD: The License field in the package spec file matches the actual license.
- GOOD: LICENSE file is in %doc.
+ GOOD: The spec file is written in American English.
+ GOOD: The spec file for the package is legible.
+ GOOD: The sources used to build the package matches the upstream source,
as provided in the spec URL.
8a76c03579a3e27046e6bafe88ffd171
+ GOOD: The package successfully compiles and build into binary rpms on at
least one supported architecture.
  Koji scratch build is
  https://koji.fedoraproject.org/koji/taskinfo?taskID=1389496
+ GOOD: builds on all architectures
+ GOOD: All build dependencies are listed in BuildRequires. (builds in koji)
+ GOOD: The spec file MUST handle locales properly.
  No locale support.
+ GOOD: %post and %postun scripts OK
+ GOOD: not relocatable
+ GOOD: A package owns all directories that it creates.
+ GOOD: A package must not contain any duplicate files in the %files listing.
+ GOOD: Permissions on files must be set properly.
+ GOOD: Each package have a %clean section.
+ GOOD: Each package consistently use macros.
+ GOOD: The package contains code, or permissable content.
+ GOOD: No large documentation files, so no a -doc subpackage.
+ GOOD: Files registered in %doc does not affect the runtime of the
application.
+ GOOD: No header files.
+ GOOD: No static libraries.
+ GOOD: No pkgconfig(.pc) files.
+ GOOD: .so file is provided in -devel package.
+ GOOD: Correct Requires in -devel subpackage.
+ GOOD: No .la libtool archives.
+ GOOD: Packages does not contain GUI applications.
+ GOOD: Packages does not own files or directories owned by other packages.
+ GOOD: Runs rm -rf $RPM_BUILD_ROOT in %install
+ GOOD: All filenames in rpm packages are valid UTF-8.
+ GOOD: Includes license text.

APPROVED

Comment 5 Jan F. Chadima 2009-06-02 15:06:26 UTC
New Package CVS Request
=======================
Package Name: libssh
Short Description: A library implementing the SSH2 protocol (0xbadc0de version)
Owners: jfch2222
Branches: F10 F11
InitialCC:

Comment 6 Peter Lemenkov 2009-06-02 18:11:16 UTC
*** Bug 503753 has been marked as a duplicate of this bug. ***

Comment 7 Jason Tibbitts 2009-06-03 17:17:49 UTC
Please note that branch names are "F-10" and "F-11".

CVS done.

Comment 8 Matěj Cepl 2009-06-04 14:21:24 UTC
Build as http://koji.fedoraproject.org/koji/buildinfo?buildID=104812

Comment 9 Orion Poplawski 2012-12-11 16:13:02 UTC
I'd like to see this in EPEL6.  I can maintain it there if the current maintainer does not.

Comment 10 Simone Caronni 2013-06-07 16:30:35 UTC
Package Change Request
======================
Package Name: libssh
New Branches: el6
Owners: slaanesh

Comment 11 Gwyn Ciesla 2013-06-07 16:50:33 UTC
Git done (by process-git-requests).

Comment 12 Simone Caronni 2013-07-18 17:15:06 UTC
Package Change Request
======================
Package Name: libssh
New Branches: el5
Owners: slaanesh

Comment 13 Gwyn Ciesla 2013-07-18 17:17:32 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.