Spec URL: http://ruben.fedorapeople.org/sendxmpp.spec SRPM URL: http://ruben.fedorapeople.org/sendxmpp-0.0.8-1.fc11.src.rpm Description: A perl script to send xmpp messages
A couple comments after a quick once-over: This package isn't delivering any modules (*.pm), so we can safely omit the "requires: perl(:MODULE_COMPAT...)". Group is largely irrelevant these days (AFAIK), but there's probably a better one than Development/Libraries. The description should probably end with a "." :) README should be included in %doc.
Thanks Chris, fixed all of the issues. New version here: Spec URL: http://ruben.fedorapeople.org/sendxmpp.spec SRPM URL: http://ruben.fedorapeople.org/sendxmpp-0.0.8-2.fc11.src.rpm
This is somewhat trivial; nobody's looked at it in a while so I'll tale a look. * source files match upstream. sha256sum: 10e0a8d03f504f93ee4b9178c86f1882ac718e76d427602b1f9e10653cde0dde sendxmpp-0.0.8.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: sendxmpp = 0.0.8-2.fc12 = /usr/bin/perl perl(Getopt::Long) perl(Net::XMPP) perl(strict) * %check is not present; no test suite upstream. I don't really have a way to test this since I don't use jabber. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED The package review process needs reviewers! If you haven't done any package reviews recently, please consider doing one.
Thanks for the review Jason! New Package CVS Request ======================= Package Name: sendxmpp Short Description: A perl script to send xmpp messages Owners: ruben Branches: F-10 F-11
CVS done.
Package Change Request ====================== Package Name: sendxmpp New Branches: epel7 Owners: robert
Git done (by process-git-requests).