Spec URL: http://fedorapeople.org/~cweyl/review/perl-PDF-Reuse.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-PDF-Reuse-0.35-1.fc10.src.rpm Description: This module allows you to reuse PDF-files. You can use pages, images, fonts and Acrobat JavaScript from old PDF-files (if they were not encrypted), and rearrange the components, and add new graphics, texts etc. There is also support for graphics. In the tutorial there is a description of how to transform simple PDF-pages to graphic Perl objects with the help of programs based on this module. The module is fairly fast, so it should be possible to use it for mass production. *rt-0.10
OK Rpmlint must be run on every package. OK The package must be named according to the Package Naming Guidelines. OK The spec file name must match the base package %{name}. OK The package must meet the Packaging Guidelines. OK The package must be licensed with a Fedora approved license. OK The License field in the package spec file must match the actual license. OK If (and only if) the source package includes the text of the license(s) in its own file. OK The spec file must be written in American English. OK The spec file for the package MUST be legible. OK The sources used to build the package must match the upstream source. 1e2541eacaf8df4f4012312f6c353688 OK The package MUST successfully compile. OK Correct BuildRequires. OK Proper use of %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden. OK Shared library files (not just symlinks) must call ldconfig in %post and %postun. OK Relocatable package must state this fact in the request for review. OK A package must own all directories that it creates. OK A package must not contain any duplicate files in the %files listing. OK Permissions on files must be set properly. OK Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK Each package must consistently use macros. OK The package must contain code, or permissable content. OK Large documentation files must go in a -doc subpackage. OK If a package includes something as %doc, it must not affect the runtime of the application. OK Header files must be in a -devel package. OK Static libraries must be in a -static package. OK Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK Library files with a suffix (e.g. libfoo.so.1.1) and files that end in .so (without suffix) must go in -devel. OK In the vast majority of cases, devel packages must require the base package. OK Packages must NOT contain any .la libtool archives. OK Packages containing GUI applications must include a %{name}.desktop file. OK At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
Ooops, sorry. I've overlooked, it was already taken.
I am actually waiting for perl-Text-PDF to be built for rawhide so that I can continue with this review.
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=1403722
APPROVED.
New Package CVS Request ======================= Package Name: perl-PDF-Reuse Short Description: Reuse and mass produce PDF documents Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
CVS done.
Thanks for the review! :-)