Bug 506956 - Various minor issues with systemtap initscript
Summary: Various minor issues with systemtap initscript
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: systemtap
Version: 5.4
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Linda Wang
QA Contact: BaseOS QE
URL:
Whiteboard:
Depends On:
Blocks: 525407
TreeView+ depends on / blocked
 
Reported: 2009-06-19 14:28 UTC by Petr Muller
Modified: 2016-09-20 02:05 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 525407 (view as bug list)
Environment:
Last Closed: 2010-06-03 15:35:33 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Petr Muller 2009-06-19 14:28:50 UTC
Version:
systemtap-initscript-0.9.7-5.el5

Description of problem:

1) Few commands are probably missing a linebreak, so they don't look very well when used. At least a space would look better.

# service systemtap start            
Starting systemtap:Compiling one ...done                        
Starting one ...done

# service systemtap cleanup
Cleaning up systemtap:Removing caches

# service systemtap compile
Compiling systemtap:Updating caches

2) Compile command output doesn't make sense: 'compiling systemtap' is not true, 'compiling systemtap scripts' is.

3) status command doesn't print any output when run with no scripts in script.d. Something like 'No systemtap scripts present' would be nice to have.

# service systemtap status

#

4) restart command should work like 'start' when everything is stopped, but it does not:

# service systemtap status
one is stopped

# service systemtap restart
Starting systemtap:                                        [WARNING]
# service systemtap status
one is stopped

5) -y (say 'yes' to all querys) doesn't work. Other options seem to work fine.
# service systemtap cleanup -y
getopt: invalid option -- y
Usage: systemtap {start|stop|restart|status|compile|cleanup} [option]
Options:
        -c configfile   : specify config file
        -r kernelrelease: specify kernel release version
        -R              : recursively dependency checking
        -y              : answer yes for all questions.
        script(s)       : specify systemtap scripts
# service systemtap compile  -y
getopt: invalid option -- y
Usage: systemtap {start|stop|restart|status|compile|cleanup} [option]
Options:
        -c configfile   : specify config file
        -r kernelrelease: specify kernel release version
        -R              : recursively dependency checking
        -y              : answer yes for all questions.
        script(s)       : specify systemtap scripts

Comment 1 Masami Hiramatsu 2009-06-19 17:17:13 UTC
Thank you for reporting!

(In reply to comment #0)
> 1) Few commands are probably missing a linebreak, so they don't look very well
> when used. At least a space would look better.

OK, I'll add a space.

> 2) Compile command output doesn't make sense: 'compiling systemtap' is not
> true, 'compiling systemtap scripts' is.

Sure, and I'd like to change stop command message too.

> 3) status command doesn't print any output when run with no scripts in
> script.d. Something like 'No systemtap scripts present' would be nice to have.

OK.

> 4) restart command should work like 'start' when everything is stopped, but it
> does not:

OK.

> 5) -y (say 'yes' to all querys) doesn't work. Other options seem to work fine.

Ah, that's a bug. I'll fix it.

Comment 5 Frank Ch. Eigler 2010-06-03 15:35:33 UTC
systemtap-1.1 in rhel5.5 includes the above commit.


Note You need to log in before you can comment on or make changes to this bug.