Bug 507354 - RHEL5: add rh-commit-changes to git tree
RHEL5: add rh-commit-changes to git tree
Status: CLOSED NOTABUG
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
5.5
All Linux
low Severity medium
: rc
: ---
Assigned To: Prarit Bhargava
Red Hat Kernel QE team
:
Depends On:
Blocks: 507355
  Show dependency treegraph
 
Reported: 2009-06-22 09:36 EDT by Prarit Bhargava
Modified: 2009-06-22 10:55 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 507355 (view as bug list)
Environment:
Last Closed: 2009-06-22 10:55:44 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
RHEL5 fix for this issue (1.42 KB, patch)
2009-06-22 09:36 EDT, Prarit Bhargava
no flags Details | Diff
RHEL5 fix for this issue (1.71 KB, patch)
2009-06-22 09:51 EDT, Prarit Bhargava
no flags Details | Diff
RHEL5 fix for this issue (2.05 KB, patch)
2009-06-22 10:03 EDT, Prarit Bhargava
no flags Details | Diff

  None (edit)
Description Prarit Bhargava 2009-06-22 09:36:37 EDT
Created attachment 348899 [details]
RHEL5 fix for this issue

Description of problem:

When executing a 'make rh-srpm' the command does not take into account uncommitted changes in the tree.

This caused me much pain :/.


Additional info:  I'm following these guidelines:

a) default behavior should be preserved.  That is, uncommitted changes should NOT be included in an srpm or rpm build.

b) the command should NOT commit changes to the tree, but rather, should put them in linux-kernel-test.patch.

Patch attached.
Comment 1 Prarit Bhargava 2009-06-22 09:51:06 EDT
Created attachment 348904 [details]
RHEL5 fix for this issue
Comment 2 Prarit Bhargava 2009-06-22 10:03:33 EDT
Created attachment 348906 [details]
RHEL5 fix for this issue

Tested version.
Comment 3 Prarit Bhargava 2009-06-22 10:55:44 EDT
dzickus mentioned that it is unneccesary to open up BZs like this.  The changes are internal only and are not verifiable by QE.

CLOSED as NOTABUG.

P.

Note You need to log in before you can comment on or make changes to this bug.