Bug 508849 - Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server implementation in POE
Review Request: perl-POE-Component-Server-Bayeux - Bayeux/cometd server imple...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jochen Schmitt
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-06-30 04:58 EDT by Yanko Kaneti
Modified: 2009-07-01 01:39 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-07-01 01:39:22 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
jochen: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Yanko Kaneti 2009-06-30 04:58:16 EDT
Spec URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Component-Server-Bayeux.spec
SRPM URL: http://declera.com/~yaneti/perl-POE-Component-Server-Bayeux/perl-POE-Component-Server-Bayeux-0.02-1.fc12.src.rpm
Description:
This module implements the Bayeux Protocol (1.0draft1) from the Dojo
Foundation. Also called cometd, Bayeux is a low-latency routing protocol
for JSON encoded events between clients and servers in a publish-
subscribe model.


$ rpmlint mock/fedora-rawhide-x86_64/result/perl-POE-Component-Server-Bayeux-0.02-1.fc12.*.rpm mock/fedora-10-i386/result/perl-POE-Component-Server-Bayeux-0.02-1.fc10.*.rpm
4 packages and 0 specfiles checked; 0 errors, 0 warnings.
Comment 1 Jochen Schmitt 2009-06-30 15:26:52 EDT
Good:
+ Basename of SPEC files matches with package name
+ Package name fullfill naming guidelines
+ URL tag shows on proper project homepage
+ Could download upstream sources via spectool -g
+ Package source tar ball matches with upstream
(md5sum: dd18ab3f61f390fbc96a8dc8a15aa447)
* Package has proper License tag
+ License Tag says GPLv2 and Artistic as OSS license
* Copyright note in the source files matches with license tag
+ Package has proper Buildroot definition
+ Consistently usage of rpm macros
+ Proper Buildroot definition
+ BuidRoot will be clean at the beginning of %clean and %install
+ Package will be built for noarch
* Local build works fine
+ Package has a %check stanza
+ Rpmlint is quite for source rpm
+ rpmlint is quite for binary rpm
+ Scratch build on koji works fine
+ Local install and uninstall works fine
+ %doc stanza is small, no extra subpackage in required
+ Files has proper files permission
+ %files contains no duplicated entries
+ All packaged files are owned by this package
+ No packaged files belong to another package
+ package has proper Changelog


Bad:
- Package doesn't contains verbain copy of the license (no blocker)



** APPROVED **
Comment 2 Yanko Kaneti 2009-06-30 17:18:20 EDT
New Package CVS Request
=======================
Package Name: perl-POE-Component-Server-Bayeux
Short Description: Bayeux/cometd server implementation in POE
Owners: yaneti
Branches: F-10 F-11
InitialCC: perl-sig
Comment 3 Jason Tibbitts 2009-06-30 22:44:17 EDT
CVS done.
Comment 4 Yanko Kaneti 2009-07-01 01:39:22 EDT
Imported. Builds done. Bodhi updates pending.
Thanks for the review.

Note You need to log in before you can comment on or make changes to this bug.