Description of problem: Prompts longer than the width of the terminal are not properly matched by #prompt. Version-Release number of selected component (if applicable): 1.2.15-1.fc11 How reproducible: Always. Steps to Reproduce: 1. define #prompt that matches all MUME prompts 2. connect to MUME and get a long enough prompt (e.g. through labelled charmies) in gameplay Actual results: Defined #prompt doesn't trigger on the long prompt. Expected results: Defined #prompt triggers on the long prompt. Additional info: In earlier versions of powwow, I've been using special patch for this, which might have some side effects though (yet I didn't see any); here it is: --- main.c.orig 2005-10-22 01:21:48.000000000 +0200 +++ main.c 2006-01-24 15:05:44.000000000 +0100 @@ -693,7 +693,7 @@ * match #prompts. They usually have no #print, so we print manually * if islast is not set and a #prompt matches. */ - if ((is_iac_prompt || islast || printstrlen(linestart) < cols) && + if (/*(is_iac_prompt || islast || printstrlen(linestart) < cols) && */ ((search_prompt(linestart, 1) && surely_isprompt) || is_iac_prompt)) { char *reprint;
Does the problem go away if you do "#request prompt"?
No, it does not.
Problem actually goes away after "#request prompt", but one must not use mmapper2. With mmapper2 it doesn't go away even then. But anyway, this is just a workaround which doesn't happen to work when other software is used. The original bug is still there. (It should work even without #request prompt)
Created attachment 356570 [details] patch: match prompts longer than terminal width
Please test the attached patch, it should properly fix the issue.
Created attachment 356631 [details] updated patch to fix long prompt matching I had missed a case with IAC end-of-prompt marker. However, now the patch is down to oneliner.
powwow-1.2.15-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/powwow-1.2.15-3.fc11
powwow-1.2.15-3.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/powwow-1.2.15-3.fc10
powwow-1.2.15-3.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8368
powwow-1.2.15-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8408
Long prompts now work correctly, but occasionally some of the prompts (witnessed on 2 short prompts so far) don't get matched against the defined #prompts. It happens very rarely though, and so far I've not been able to identify a common pattern.
powwow-1.2.16-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/powwow-1.2.16-1.fc10
powwow-1.2.16-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/powwow-1.2.16-1.fc11
powwow-1.2.16-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-9237
powwow-1.2.16-1.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update powwow'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-9245
powwow-1.2.16-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
powwow-1.2.16-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.