Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ValidateRM/perl-CGI-Application-Plugin-ValidateRM.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ValidateRM/perl-CGI-Application-Plugin-ValidateRM-2.3-1.fc11.src.rpm Description: CGI::Application::Plugin::ValidateRM helps to validate web forms when using the CGI::Application framework and the Data::FormValidator module.
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1455810 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e5455459cc69eac3f495a002ddc52c1ef0d43414 CGI-Application-Plugin-ValidateRM-2.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=20, 1 wallclock secs ( 0.04 usr 0.02 sys + 0.42 cusr 0.06 csys = 0.54 CPU) + Package perl-CGI-Application-Plugin-ValidateRM-2.3-1.fc12.noarch=> Provides: perl(CGI::Application::Plugin::ValidateRM) = 2.3 Requires: perl(Data::FormValidator) perl(Exporter) perl(HTML::FillInForm) perl(strict) perl(vars) + Not a GUI application APPROVED.
Ah! directory ownership issue. I am revoking approval. please submit new spec Change %attr(644,root,root) %{perl_vendorlib}/CGI/Application/Plugin/ValidateRM.pm to %{perl_vendorlib}/*
(In reply to comment #2) > Ah! directory ownership issue. I am revoking approval. please submit new spec > Change > %attr(644,root,root) %{perl_vendorlib}/CGI/Application/Plugin/ValidateRM.pm > to > %{perl_vendorlib}/* Done. I've also added a chmod line to fix the file's permissions. Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ValidateRM/perl-CGI-Application-Plugin-ValidateRM.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-ValidateRM/perl-CGI-Application-Plugin-ValidateRM-2.3-2.fc11.src.rpm
http://koji.fedoraproject.org/koji/taskinfo?taskID=1456569 APPROVED.
(In reply to comment #4): > > APPROVED. Thanks, Parag. Requesting CVS. New Package CVS Request ======================= Package Name: perl-CGI-Application-Plugin-ValidateRM Short Description: Help validate CGI::Application run modes using Data::FormValidator Owners: eseyman Branches: F-11 F-10 InitialCC: perl-sig
cvs done.
perl-CGI-Application-Plugin-ValidateRM-2.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-ValidateRM-2.3-2.fc11
perl-CGI-Application-Plugin-ValidateRM-2.3-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-CGI-Application-Plugin-ValidateRM'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-7445
perl-CGI-Application-Plugin-ValidateRM-2.3-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.