Spec URL: http://nimbius.36bit.com/epic5.spec SRPM URL: http://nimbius.36bit.com/epic5-1.0-1.fc11.src.rpm Description: epic5 is the latest version of Epic, a chat client based on the ircII client.
Why not just upgrade the existing version?
vcrhonek: what do you think?
I mentioned an upgrade to the last user cited in the changelog for epic4, but no response. 4 and 5 are similar, but their scripts are not compatible.
spec file is a mess use macros instead of hard coded path. http://www.fedoraproject.org/wiki/Packaging:RPMMacros /usr/share/epic5/script/ should be %{_datadir}/%{name}/script Package must own all directories it creates. http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script Shorten list by using %{_datadir}/%{name}/script/* No %changelog entry Package does not build as is.
(In reply to comment #4) > spec file is a mess use macros instead of hard coded path. > > http://www.fedoraproject.org/wiki/Packaging:RPMMacros > /usr/share/epic5/script/ should be %{_datadir}/%{name}/script > > Package must own all directories it creates. > > http://www.fedoraproject.org/wiki/Packaging/Guidelines#FileAndDirectoryOwnership > use %dir %{_datadir}/%{name} and %dir %{_datadir}/%{name}/script > > Shorten list by using %{_datadir}/%{name}/script/* Yes, it seems to be rather a mess. %{_datadir}/epic5/ should be owned too, so the files section would end up as %{_bindir}/epic5 %{_bindir}/epic5-1.0 %{_datadir}/epic5/ %{_mandir}/man1/epic5.1.* %{_libexecdir}/epic5-wserv4 <- add trailing slash if this is a directory - The Requires Requires: ncurses-devel >= 5.7-2 Requires: ruby-devel >= 1.8.6 Requires: perl-ExtUtils-Embed >= 1.28-69 should be BuildRequires. Also, you probably need perl-devel. - Contact upstream so that they fix SMP make. - The install command should be make install IP=$RPM_BUILD_ROOT INSTALL_PROGRAM="install -c -p -m 755" INSTALL_DATA="install -c -p -m 644" to preserve time stamps (OK, not essential for the binaries). I have no idea why make install compiles some test program, but it isn't installed so the optflags are not needed in install. - You could also ask upstream to change IP to the standard DESTDIR in the makefile.
Thanks very much for the valuable input! and sorry for wasting time by not reading the aforementioned docs. upstream maintainer has been warned of bugs, and im rebuilding the spec file to look less like the taco bell value menu.
Hi, Is this your first package? I'm unable to find you in packager group nor any other package review request from you. If yes, please go ahead http://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account and put FE-NEEDSPONSOR into Blocks field. if no, what is your FAS username?
applied in accordance with requirements at the given url. blocks field populated. anxiety abounds. still waiting on the upstream to fix SMP make...
please don't use full path to files like: /usr/share/epic5/script/... which is in your %files section, use appropriate macro
any update?
debugging the smp build fail with devs at epic. cleaning up my .spec so it builds on more than my pc.
What is the status of this bug?
anything new or should we just close the bug?
will close the bug in one week unless we have an update by then.
(In reply to comment #14) > will close the bug in one week unless we have an update by then. Closing as one week passed. If someone wants to import this package into Fedora, please submit a new review request and mark this bug as a duplicate of the new one, thank you.