Bug 511277 - Review Request: comoonics-cluster-py - general cluster library for querying different clusters (used for open-sharedroot)
Summary: Review Request: comoonics-cluster-py - general cluster library for querying d...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 511276
Blocks: 511280
TreeView+ depends on / blocked
 
Reported: 2009-07-14 14:42 UTC by Marc Grimme
Modified: 2009-11-19 08:57 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-19 08:57:30 UTC
Type: ---
Embargoed:
nphilipp: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Marc Grimme 2009-07-14 14:42:49 UTC
Spec URL: http://www.open-sharedroot.org/development/comoonics-cluster-py/comoonics-cluster-py.spec
SRPM URL: http://www.open-sharedroot.org/development/comoonics-cluster-py/comoonics-cluster-py-0-1-20-src.rpm/view
Description: comoonics-cluster-py
Python libraries for querying different cluster types. 
Examples are Red Hat Cluster, Oracle Cluster and NFS-Sharedroot clusters based on Red Hat Cluster configuration.

This library is used to introduce and abstraction layer for querying different clustertypes.

This library is required for the open-sharedroot feature:  https://fedoraproject.org/wiki/Features/Opensharedroot

It depends on comoonics-base-py. See bugzilla .

This is my first package. Therefore I need a sponsor. Thanks !!

Comment 1 Nils Philippsen 2009-07-15 12:18:42 UTC
I'll take this.

Comment 3 Nils Philippsen 2009-07-22 08:09:37 UTC
Items marked "GOOD" or "PASS" fulfil the guidelines or they don't apply to this package.
Items marked "CHECK" aren't covered by the guidelines but you should check and fix them anyway in my opinion.
Items marked "BAD" violate the guidelines in some point and need to be fixed.

- GOOD: rpmlint run on doesn't flag errors/warnings
- GOOD: package name according to guidelines
- GOOD: spec file named properly
- GOOD: package meets packaging guidelines
- GOOD: licensed according to licensing guidelines
- GOOD: license in spec file matches license in package
- GOOD: license shipped as documentation
- GOOD: the spec file is written in American English
- GOOD: the spec file is legible
- GOOD: sources used to build the package match upstream source

--> remember to bump the version if you make changes to the tarball (from now
on at least)

- GOOD: builds in mock for x86_64/Rawhide
- GOOD: all build dependencies listed
- PASS: doesn't ship locale files
- PASS: no libraries shipped
- GOOD: package is not relocatable
- GOOD: all shipped directories owned by package, direct dependency or filesystem
- GOOD: no duplicates in %files
- GOOD: permissions on files are set properly
- GOOD: package has a %clean section
- GOOD: package uses macros consistently
- GOOD: the package contains code, not content
- PASS: no large documentation files
- GOOD: %doc doesn't affect runtime
- PASS: no header files
- PASS: no static libraries
- PASS: no pkgconfig files
- PASS: no libraries included
- PASS: no devel package
- GOOD: no *.la libtool archives
- PASS: no desktop file
- GOOD: doesn't own files or directories owned by other packages
- GOOD: build root is cleaned at the beginning of %install
- GOOD: all file names are valid UTF-8

This package is APPROVED.

Comment 4 Marc Grimme 2009-07-23 11:06:38 UTC
New Package CVS Request
=======================
Package Name: comoonics-cluster-py
Short Description: Comoonics cluster configuration utilities written in Python 
Owners: Marc Grimme Mark Hlawatschek
Branches: devel
InitialCC:

Comment 5 Jason Tibbitts 2009-07-23 16:41:18 UTC
Unfortunately the owners need to be FAS account names, not your actual real names.  Could you make a revised request?

Comment 6 Marc Grimme 2009-07-23 21:07:26 UTC
New Package CVS Request
=======================
Package Name: comoonics-cluster-py
Short Description: Comoonics cluster configuration utilities written in Python 
Owners: elcody02 markhla
Branches: devel
InitialCC:

Comment 7 Jason Tibbitts 2009-07-24 19:19:03 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.