Spec URL: http://www.kernel.org/pub/software/network/distsrv/pkg/tabled.spec SRPM URL: http://www.kernel.org/pub/software/network/distsrv/pkg/tabled-0.3git-3.fc10.src.rpm Description: distributed data storage service tabled is a scalable, distributed (key, value) storage service for cloud computing. Keys may be up to 1k, values may be any size. This attempts to provide a service that is compatible with Amazon S3 clients. This package REQUIRES "cld" and "chunkd", two packages also submitted for Fedora review.
Created attachment 354038 [details] Updated tabled spec file Updated tabled spec file
Created attachment 354039 [details] Updated tabled SRPM file. I updated the spec file for review comments found in tabled's pre-req packages (reviews: bug #511938 and #511941), plus a few things found in a re-review of the packaging guidelines.
Created attachment 354071 [details] Updated tabled spec file
Created attachment 354072 [details] Updated tabled SRPM file. Updated with review feedback from sister project cld (bug #511938): - add more %doc - %config(noreplace) - chkconfig default off - convert spaces to tabs (rpmlint)
Created attachment 354193 [details] Updated tabled spec file
Created attachment 354194 [details] Updated tabled SRPM file. Updated with feedback to sister project cld (bz# 511938): - new release version numbering scheme
Because the source comes from revision control it needs to be documented how to recreate the tarfile so the source file can be verified using ms5sum etc to ensure its from upstream. Details here: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
I'm not sure the LICENSE file is relevant. It mentions ethtool and contains no LICENSE text which is contained in COPYING. Might be worth checking with upstream.
A couple of things. The main one is the documentation on how to recreate the source file. Also the description could be fleshed out a little the one used in the review request is quite good. I couldn't build it in koji due to dep on chunkd. + rpmlint output rpmlint tabled-0.3-0.1.g2783d260.fc10.src.rpm tabled.spec 1 packages and 1 specfiles checked; 0 errors, 0 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + %doc includes license file + spec file written in American English + spec file is legible ? upstream sources match sources in the srpm needs to update to the revision control packaging guidelines https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control n/a package successfully builds on at least one architecture not tested in koji as it requires chunkd (should be a dep in the review bug) + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* + binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr + package owns all directories it creates + no duplicate files in %files + %defattr line + %clean contains rm -rf %{buildroot} + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package + header files should be in -devel n/a static libraries should be in -static + packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' + libfoo.so must go in -devel + devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + %install must start with rm -rf %{buildroot} etc. + filenames must be valid UTF-8 Optional: n/a if there is no license file, packager should query upstream n/a translations of description and summary for non-English languages, if available n/a reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin
Created attachment 354284 [details] Updated tabled spec file
Created attachment 354285 [details] Updated tabled SRPM file. Updated for review comments, notably: * expanded description * fixed LICENSE * described how to regen source tarball Cannot build in koji due to dep on chunkd (not yet in rawhide).
Looks fine now. APPROVED!
New Package CVS Request ======================= Package Name: tabled Short Description: Scalable, distributed key/value lookup table service Owners: jgarzik zaitcev Branches: F-10 F-11 InitialCC:
CVS done.
Closing as its now in rawhide :-)