Spec URL: http://fedorapeople.org/~iarnell/review/perl-Algorithm-IncludeExclude.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Algorithm-IncludeExclude-0.01-1.fc12.src.rpm Description: Algorithm::IncludeExclude lets you define a tree of include / exclude rules and then allows you to determine the best rule for a given path. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1485225 *rt-0.09
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1485225 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d8a1f06a5e5ac39db1a5e8750157c270 Algorithm-IncludeExclude-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=13, Tests=71, 2 wallclock secs ( 0.18 usr 0.04 sys + 0.88 cusr 0.19 csys = 1.29 CPU) Result: PASS + Package perl-Algorithm-IncludeExclude-0.01-1.fc12.noarch Provides: perl(Algorithm::IncludeExclude) = 0.01 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 perl(Carp) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-Algorithm-IncludeExclude Short Description: Build and evaluate include/exclude lists Owners: iarnell Branches: F-10 F-11 InitialCC: perl-sig
cvs done.
perl-Algorithm-IncludeExclude-0.01-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Algorithm-IncludeExclude-0.01-1.fc11
perl-Algorithm-IncludeExclude-0.01-1.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/perl-Algorithm-IncludeExclude-0.01-1.fc10
Thanks for the review! :-)
perl-Algorithm-IncludeExclude-0.01-1.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.
perl-Algorithm-IncludeExclude-0.01-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.