Spec URL: http://ruben.fedorapeople.org/perl-Math-Calc-Units.spec SRPM URL: perl-Math-Calc-Units-1.06-1.fc11.src.rpm Description: Math::Calc::Units is a simple calculator that keeps track of units. It currently handles combinations of byte sizes and duration only, although adding any other multiplicative types is easy. Any unknown type is treated as a unique user type (with some effort to map English plurals to their singular forms).
Oops, srpm is here: http://ruben.fedorapeople.org/perl-Math-Calc-Units-1.06-1.fc11.src.rpm
Review: + package builds in mock (rawhide i586). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1534316 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 546e95dc449cdec8410edb6739a5229d5a63f644 Math-Calc-Units-1.06.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=2, Tests=64, 0 wallclock secs ( 0.03 usr 0.00 sys + 0.14 cusr 0.01 csys = 0.18 CPU) + Package perl-Math-Calc-Units-1.06-1.fc12.noarch => Provides: perl(Math::Calc::Units) = 1.06 perl(Math::Calc::Units::Compute) perl(Math::Calc::Units::Convert) perl(Math::Calc::Units::Convert::Base) perl(Math::Calc::Units::Convert::Base2Metric) perl(Math::Calc::Units::Convert::Byte) perl(Math::Calc::Units::Convert::Combo) perl(Math::Calc::Units::Convert::Date) perl(Math::Calc::Units::Convert::Distance) perl(Math::Calc::Units::Convert::Metric) perl(Math::Calc::Units::Convert::Multi) perl(Math::Calc::Units::Convert::Time) perl(Math::Calc::Units::Grammar) perl(Math::Calc::Units::Rank) Requires: /usr/bin/perl perl >= 0:5.004 perl(Carp) perl(Getopt::Long) perl(Math::Calc::Units) perl(Math::Calc::Units::Compute) perl(Math::Calc::Units::Convert) perl(Math::Calc::Units::Convert::Byte) perl(Math::Calc::Units::Convert::Combo) perl(Math::Calc::Units::Convert::Date) perl(Math::Calc::Units::Convert::Distance) perl(Math::Calc::Units::Convert::Multi) perl(Math::Calc::Units::Convert::Time) perl(Math::Calc::Units::Rank) perl(Time::Local) perl(base) perl(constant) perl(strict) perl(vars) + Not a GUI application Should: 1) Source URL worked for me is actually http://search.cpan.org/CPAN/authors/id/S/SF/SFINK/Math-Calc-Units-1.06.tar.gz update the same in SPEC. 2) Correct license tag to "GPLv2+ or Artistic" COPYING file says its GPLv2+
Thanks for the review, all issues are fixed. New version: Spec URL: http://ruben.fedorapeople.org/perl-Math-Calc-Units.spec SRPM URL: perl-Math-Calc-Units-1.06-2.fc11.src.rpm
APPROVED.
New Package CVS Request ======================= Package Name: perl-Math-Calc-Units Short Description: Human-readable unit-aware calculator Owners: ruben Branches: F-11
cvs done.
perl-Math-Calc-Units-1.06-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Math-Calc-Units-1.06-2.fc11
perl-Math-Calc-Units-1.06-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-Math-Calc-Units'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8395
perl-Math-Calc-Units-1.06-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Ruben, Any chance of EL-5 branches for this perl module and perl-Nagios-Plugin (#517497) ? tia, jpo
Sure, I don't have nagios running on EL-5, so won't be able to test. Do you want to co-maintain?
(In reply to comment #11) > Sure, I don't have nagios running on EL-5, so won't be able to test. Do you > want to co-maintain? Ruben, Feel free to add me as a co-maintainer of perl-Math-Calc-Units and perl-Nagios-Plugin. I'll handle the EPEL tickets. /jpo
Package Change Request ====================== Package Name: perl-Nagios-Plugin New Branches: EL-5 Owners: ruben jpo
Did you mean perl-Math-Calc-Units here?
(In reply to comment #14) > Did you mean perl-Math-Calc-Units here? Yes (perl-Math-Calc-Units is needed by perl-Nagios-Plugin). /jpo
perl-Math-Calc-Units * already in the epel-testing repos (tag: dist-5E-epel-testing) perl-Nagios-Plugin * still waiting for rel-eng to build it (trac#2173) /jpo
Update: Both modules are now available in EPEL-5 Testing repos. /jpo
Ruben, Do you mind if I request an EL-6 branch for this perl module and for perl-Nagios-Plugin? I don't mind co-maintaining them. Regards, jpo
Hi Jose, No problem, please do! Regards, Ruben
Package Change Request ====================== Package Name: perl-Math-Calc-Units New Branches: EL-6 Owners: ruben jpo
An el6 branch of this package already exists, you know. Not sure what you're asking us to do here.