Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/FUR.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/FUR-0.4.6-1.fc11.src.rpm Description: FUR is an application that let the user mount a Windows CE based device on your Linux file system: it uses the brilliant FUSE and the librapi2 of the Synce Project (a *nix implementation of the RAPI protocol that your device uses to communicate with your other operating system) to give you the illusion that the storage of your Pocket PC is a directory on your local filesystem.
Seems valuable and has clean spec-file. I'll review it very soon.
I see the only blocker issue so far - missing "Requires: fuse". The package "fuse" (due to different licensing terms is splitted to fuse and fuse-libs, but rpm can pick up only fuse-libs automatically. Also, I suggest to shorten spec a little - you may replace mkdir -p $RPM_BUILD_ROOT%{_bindir} install -p -m 755 Fur $RPM_BUILD_ROOT%{_bindir}/Fur by the single line ("install" utility can create directories): install -D -p -m 755 Fur $RPM_BUILD_ROOT%{_bindir}/Fur Note the "-D" switch. Ok, here is my REVIEW: - rpmlint is not silent. [petro@Sulaco ppc]$ rpmlint FUR-0.4.6-1.fc11.ppc.rpm FUR.ppc: W: invalid-license GPL 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [petro@Sulaco ppc] + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec . +/- The package meets the Packaging Guidelines (except few issues, noted above). + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . - The License field in the package spec file must match the actual license (GPLv2) + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source, as provided in the spec URL. [petro@Sulaco SOURCES]$ md5sum FUR-0.4.6.tar.gz* 76688e4b208e33d72e53c0f7dcc59534 FUR-0.4.6.tar.gz 76688e4b208e33d72e53c0f7dcc59534 FUR-0.4.6.tar.gz.1 [petro@Sulaco SOURCES]$ + The package successfully compiles and builds into binary rpms on at least one primary architecture: http://koji.fedoraproject.org/koji/taskinfo?taskID=1562071 + All build dependencies are listed in BuildRequires. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + Everything, the package includes as %doc, does not affect the runtime of the application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in the package are valid UTF-8. Please take care of issues. mentioned by me, and I'll finish my review.
(In reply to comment #2) > I see the only blocker issue so far - missing "Requires: fuse". Of course, good catch. I counted too much on RPM's automatic dependencies. > Also, I suggest to shorten spec a little - you may replace [...] done. > - The License field in the package spec file must match the actual license > (GPLv2) fixed. http://gauret.free.fr/fichiers/rpms/fedora/synce/FUR-0.4.6-2.fc11.src.rpm
OK, I can't see any other issues here, so this package is APPROVED.
New Package CVS Request ======================= Package Name: FUR Short Description: Mount a Windows CE based device on your Linux file system Owners: abompard awjb Branches: F-10 F-11 InitialCC:
CVS done.
Built, thanks !
FUR-0.4.6-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/FUR-0.4.6-2.fc11
FUR-0.4.6-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.