Bug 514342 - Review Request: rubygem-fattr - Fatter attribute for Ruby
Summary: Review Request: rubygem-fattr - Fatter attribute for Ruby
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-07-28 21:37 UTC by Jeroen van Meeuwen
Modified: 2009-08-27 07:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-08-27 07:01:16 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Jeroen van Meeuwen 2009-07-28 21:37:07 UTC
Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-fattr.spec
SRPM URL: http://www.kanarip.com/custom/f11/SRPMS/rubygem-fattr-1.0.3-1.fc11.src.rpm
Description: Fatter attribute for Ruby

A new requirement for rubygem-main.

rpmlint is silent.

Comment 1 Mamoru TASAKA 2009-08-04 16:40:19 UTC
Well, where is license information?

Comment 2 Mamoru TASAKA 2009-08-11 14:41:30 UTC
ping?

Comment 3 Jeroen van Meeuwen 2009-08-12 21:47:49 UTC
This piece is from codeforpeople and I had mistakenly assumed the license was MIT; according to http://rubyforge.org/projects/codeforpeople/ which lists fattr, the license should be Ruby;

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-fattr.spec
New SRPM: http://www.kanarip.com/custom/f11/SRPMS/rubygem-fattr-1.0.3-2.fc11.src.rpm

Comment 4 Mamoru TASAKA 2009-08-13 07:58:46 UTC
Approving, provided:

- Please add the following text file as %doc:
  http://codeforpeople.com/lib/license.txt
  (In the spec file add this with _full URL_ like
------------------------------------------------------------------
URL:            http://rubyforge.org/projects/codeforpeople/
Source0:        http://gems.rubyforge.org/gems/%{gemname}-%{version}.gem
Source1:        http://codeforpeople.com/lib/license.txt
...
...
%install
rm -rf %{buildroot}
mkdir -p %{buildroot}%{gemdir}
...
...
install -p -m 644 %{SOURCE1} %{buildroot}%{geminstdir}/
...
...
%files
...
%doc %{geminstdir}/license
....
------------------------------------------------------------------

- If we say "the license is the same as Ruby's", on Fedora this
  means it is licensed under "GPLv2 or Ruby" (on Fedora "Ruby" license
  means the lines below "or the conditions below:" of
  http://www.ruby-lang.org/en/LICENSE.txt), so please
  change the license tag to "GPLv2 or Ruby" (not GPLv2+ or)

-----------------------------------------------------------------
    This package (rubygem-fattr) is APPROVED by mtasaka
-----------------------------------------------------------------

Comment 5 Jeroen van Meeuwen 2009-08-13 20:48:29 UTC
Thanks;

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-fattr.spec
New SRPM: http://www.kanarip.com/custom/f11/SRPMS/rubygem-fattr-1.0.3-3.fc11.src.rpm

New Package CVS Request
=======================
Package Name: rubygem-fattr
Short Description: Fatter attribute for Ruby
Owners: kanarip
Branches: EL-4 EL-5 F-10 F-11 devel
InitialCC:

Comment 6 Jason Tibbitts 2009-08-14 16:18:06 UTC
CVS done.

Comment 7 Fedora Update System 2009-08-20 21:02:07 UTC
rubygem-fattr-1.0.3-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-fattr'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8805

Comment 8 Mamoru TASAKA 2009-08-27 07:01:16 UTC
Now closing.


Note You need to log in before you can comment on or make changes to this bug.