Spec URL: http://www.auroralinux.org/people/spot/review/new/xblas.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/xblas-1.0.248-1.fc12.src.rpm
The XBLAS library of routines is part of a reference implementation for
the Dense and Banded Basic Linear Algebra Subroutines, along with their
Extended and Mixed Precision versions, as documented in Chapters 2 and 4
of the new BLAS Standard.
Just curious, why the call to autoconf at the end of the prep section?
After a general analysis of the spec it looks like it was taken from a schoolbook. ;-)
Because the patch for shared support applies to configure.ac, rather than configure, I need to rerun autoconf.
As to the schoolbook nature of the spec, that's a good thing, right? :)
Yes, I noticed that after reading the documentation. Sorry. :-)
Being an assistant professor I can say that the schoolbook nature of the spec is a bonus. :-)
Expect a full review soon.
The source package is the same as upstream.
The license is correct (BSD) and appropriate for Fedora. This is even more appropriate in the case since the copyright comes from Berkeley. :-)
The package build in the supported Fedora architectures. (see #2)
Build on F11 and rawhide.
The package follows the packaging guidelines.
The package is _approved_.
PS: One small detail, I noticed that you have placed README.devel in the devel sub-package, after reading it I am not sure how useful the file is. I think that the content is useless for any developer, but I leave to you the final decision.
The README file on the other hand is really helpful and in a sense it belongs more to devel than to the main package. If you think that I am being pedantic in the last argument (README) then I agree with you and you are free to ignore me.
New Package CVS Request
Package Name: xblas
Short Description: Extra Precise Basic Linear Algebra Subroutines
Branches: F-10 F-11 devel
... and it's done. Thanks for the review (I did make that minor change).
xblas-1.0.248-2.fc10 has been submitted as an update for Fedora 10.
xblas-1.0.248-2.fc11 has been submitted as an update for Fedora 11.
xblas-1.0.248-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
xblas-1.0.248-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.