Spec URL: http://fedorapeople.org/~cweyl/review/perl-CatalystX-Component-Traits.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-CatalystX-Component-Traits-0.10-1.fc11.src.rpm Description: Adds a "COMPONENT" method to your Catalyst component base class that reads the optional 'traits' parameter from app and component config and instantiates the component subclass with those traits using MooseX::Traits/new_with_traits from MooseX::Traits::Pluggable. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1654079 *rt-0.10
This is a new BR of the latest Catalyst::Model::DBIC::Schema.
Review: + package builds in mock (rawhide i686). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1654079 + rpmlint is silent for SRPM and for RPM. + source files match upstream url d1c624fb4ea79869a78382ec1db95860b696d8bc CatalystX-Component-Traits-0.10.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=7, Tests=19, 3 wallclock secs ( 0.03 usr 0.01 sys + 3.28 cusr 0.20 csys = 3.52 CPU) + Package perl-CatalystX-Component-Traits-0.10-1.fc12.noarch => Provides: perl(CatalystX::Component::Traits) = 0.10 Requires: perl(Carp) perl(List::MoreUtils) perl(Moose::Role) perl(namespace::autoclean) perl(Scalar::Util) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application APPROVED.
New Package CVS Request ======================= Package Name: perl-CatalystX-Component-Traits Short Description: Automatic Trait Loading and Resolution for Catalyst Owners: cweyl Branches: F-10 F-11 devel InitialCC: perl-sig
cvs done.
Thanks for the review! :-)
Package Change Request ====================== Package Name: perl-CatalystX-Component-Traits New Branches: el6 Owners: iarnell tremble
Git done (by process-git-requests).