Bug 522356 - Review Request: lohit-tamil-fonts - Open Type Font for Tamil Language
Summary: Review Request: lohit-tamil-fonts - Open Type Font for Tamil Language
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-09-10 06:43 UTC by Pravin Satpute
Modified: 2009-09-11 11:57 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-09-11 11:57:52 UTC
panemade: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Pravin Satpute 2009-09-10 06:43:43 UTC
SPEC URL : http://pravins.fedorapeople.org/SPECS/lohit-tamil-fonts.spec

SRPM URL :
http://pravins.fedorapeople.org/SRPMS/lohit-tamil-fonts-2.4.3-1.fc11.src.rpm

This package contains open type fonts for Tamil language, Tamil script.

Please note that this were part of lohit-fonts package previously, now lohit
upstream releasing it as a separate tarball.

Comment 1 Parag AN(पराग) 2009-09-10 13:44:46 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1667834
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5eba3c34ae0798bf65e271fe3da28bc05c9c49aa  lohit-tamil-2.4.3.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ fonts scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

APPROVED.

Comment 2 Pravin Satpute 2009-09-11 04:39:40 UTC
New Package CVS Request
=======================
Package Name: lohit-tamil-fonts
Short Description: Free Tamil Open Type Font
Owners: pravins
Branches:
InitialCC: fonts-sig

Comment 3 Nicolas Mailhot 2009-09-11 06:06:21 UTC
BTW it'd really be a little cleaner if there was a real makefile in the package, even if it only contains two lines to call generate.pe

make

is a standard interface people are used to and expect, and it will also give you parallelism when you have multiple files to process

Comment 4 Jens Petersen 2009-09-11 08:55:06 UTC
cvs admin done

Comment 5 Pravin Satpute 2009-09-11 09:12:22 UTC
Nicolas,
surely in next release of upstream i will do that, for all lohit language fonts

Comment 6 Nicolas Mailhot 2009-09-11 09:47:46 UTC
Thanks. Lohit distribution practices were a lot worse for years, so it's not an urgent thing to fix. I agree there's little harm in waiting to do it for next release

Another cleanup would be to host the lohit release tarballs in the fedorahosted project, a fedorapeople space is not very professional on our part

Comment 7 Pravin Satpute 2009-09-11 11:01:02 UTC
I have some lohit fixes in queue, once those will complete i will update other suggested things as well :)

Comment 8 Pravin Satpute 2009-09-11 11:37:00 UTC
completed build
Thanks Parag and Jens


Note You need to log in before you can comment on or make changes to this bug.