Spec URL: http://repo.calcforge.org/f12/kio_gopher.spec SRPM URL: http://repo.calcforge.org/f12/kio_gopher-0.1.3-1.fc10.kde4.3.1.src.rpm Description: This KIO slave adds support for the Gopher protocol to Konqueror. F10 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1679437 F11 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1679452 F12 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1679466 (all successful on all 4 architectures) rpmlint output on SRPM, i386.rpm and -debuginfo i386.rpm: 3 packages and 0 specfiles checked; 0 errors, 0 warnings. To test, install the package and point Konqueror to: gopher://gopher.quux.org:70/1/ Compare with the web interface at: http://gopher.quux.org:70/ (Note that some links on that site don't work. They return the same errors through the web interface, so I assume this is a server side issue.) (It's interesting that the server supports both HTTP and Gopher on the same port.)
Well, quick review as this is simple package. rpmlint OK build (local OK) (in Koji OK) (archs OK) name OK URL & sources OK sources MD5 OK license OK (GPLv2+) buildroot OK works OK I'm not sure about versioning - in upstream tarball kde-4.3.1 is in version tag, in some other own packages we omit it. We should be consistent in versioning.
I can drop the kde4.3.1 tag from Release if you prefer, I'm not particularly attached to it (i.e. I'm fine with removing it). (But the guidelines do allow non-numeric versioning tags after the disttag.)
(In reply to comment #2) > I can drop the kde4.3.1 tag from Release if you prefer, I'm not particularly > attached to it (i.e. I'm fine with removing it). Well, please remove it.
Spec URL: http://repo.calcforge.org/f12/kio_gopher.spec SRPM URL: http://repo.calcforge.org/f12/kio_gopher-0.1.3-2.fc10.src.rpm * Tue Sep 15 2009 Kevin Kofler <Kevin.org> - 0.1.3-2 - drop postfix tag from Release
Ugh, the date is wrong in the changelog entry... I guess I'll fix that when importing the package. ;-)
Reuploaded with the correct changelog date (Wed Sep 16 2009). ;-)
APPROVED
You're supposed to set fedora-review+, not fedora-cvs+.
(In reply to comment #8) > You're supposed to set fedora-review+, not fedora-cvs+. Ah, thanks, my mistake... I was setting fedora-cvs+ on another review and you, sometimes you do thinks automaticaly ;-)
New Package CVS Request ======================= Package Name: kio_gopher Short Description: Gopher KIO slave for Konqueror Owners: kkofler jreznik rdieter ltinkl than svahl Branches: F-10 F-11 InitialCC: tuxbrewr
cvs done.
Imported, built.