Spec URL: http://nb.fedorapeople.org/review/sks.spec SRPM URL: http://nb.fedorapeople.org/review/sks-1.1.1-1.fc11.src.rpm Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=1745490 Description: SKS is a OpenPGP keyserver whose goal is to provide easy to deploy, decentralized, and highly reliable synchronization.
> %__make install PREFIX="%{buildroot}/usr" MANDIR="%{buildroot}/usr/share/man" This line should use macros for /usr and /usr/share/man, e.g.: %__make install PREFIX="%{buildroot}%{_bindir}" MANDIR="%{buildroot}%{_mandir}" > %files > %defattr(-,root,root) > #%doc AUTHORS LICENSE LICENSE.OpenSSL README znc.conf This commented line ... > %doc BUGS CHANGELOG COPYING FILES README TODO VERSION > %{_bindir}/sks > %{_bindir}/sks_build.sh > %{_bindir}/sks_add_mail > %{_mandir}/man8/sks.8.gz > #%{_mandir}/man1/* > #%{_libdir}/znc/ > #%{_datadir}/znc/ And these three commented lines should be removed.
Fixed. Thanks!
Using the new srpm here: http://fedorapeople.org/~nb/review/sks-1.1.1-2.fc11.src.rpm Good: * Package named appropriately. Upstream tarball and binary are sks. * Licensed GPLv2+, sources confirm * license file included in package * Spec file is legible * Source matches upstream * No locale files * Not a library package * No bundled libraries * Not relocatable * All created directories are owned and no others. * Proper %clean * macros used consistently * Code, not content * No %doc files affect the package runtime * Not a GUI application * All filenames are utf-8 * Package builds forall arches in koji * rpmlint clean * C libraries are dynamically linked * Files have good permissions APPROVED
New Package CVS Request ======================= Package Name: sks Short Description: Synchronizing Key Server Owners: nb Branches: F-10 F-11 F-12 EL-4 EL-5 InitialCC:
cvs done.