Spec URL: http://www.kanarip.com/custom/SPECS/rubygem-columnize.spec SRPM URL: http://www.kanarip.com/custom/f12/SRPMS/rubygem-columnize-0.3.1-2.fc12.src.rpm Description: Sorts an array in column order rpmlint is entirely silent for a change.
Some notes: * %check - Please add %check section as this package contains test/ directory * License - Well, while I believe this is under GPLv2+, "README" says this is under GPLv2, so it is safer that the license tag is changed to GPLv2. * %define -> %global - We now prefer to use %global rather than %define. * unused macro - The defined macro %ruby_sitelib does not seem to be used.
Would you update this?
ping?
(In reply to comment #1) > Some notes: > > * %check > - Please add %check section as this package contains test/ > directory > Fixed. > * License > - Well, while I believe this is under GPLv2+, "README" says > this is under GPLv2, so it is safer that the license tag > is changed to GPLv2. > OK, fixed. > * %define -> %global > - We now prefer to use %global rather than %define. > Fixed. > * unused macro > - The defined macro %ruby_sitelib does not seem to be used. Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-columnize.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-columnize-0.3.1-3.fc12.src.rpm
Well, ------------------------------------------------------------- 37 # Fix shebangs 38 find %{buildroot}/%{geminstdir} -type f -exec sed -r -e 's"^#!(.*)/usr/bin/env ruby"#!/usr/bin/ruby"' {} \; ------------------------------------------------------------- - This should be "-exec sed -i -e". Other things are okay. ------------------------------------------------------------- This package (rubygem-columnize) is APPROVED by mtasaka -------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-columnize Short Description: Sorts an array in column order Owners: kanarip Branches: EL-5 F-11 F-12 InitialCC:
cvs done.
Closing.
*** Bug 588429 has been marked as a duplicate of this bug. ***