Spec URL: http://5dollarwhitebox.org/tmp/perl-Net-ARP.spec SRPM URL: http://5dollarwhitebox.org/tmp/perl-Net-ARP-1.0.6-1.src.rpm Description: This module is a Perl extension to create and send ARP packets and lookup local or remote mac addresses. You do not need to install any additional libraries like Libnet to compile this extension. It uses kernel header files to create the packets.
Hi BJ, Initial comments: - Shorten the line [ "%{buildroot}" != "/" ] && %{__rm} -rf %{buildroot} to just rm -rf %{buildroot} (see PackagingGuidelines) - The package Provides ARP.so()(64bit). You might want to filter this out. Have a look at Packaging:Perl for tips on how to do this.
Both have been resolved. Scratch build is at: http://koji.fedoraproject.org/koji/taskinfo?taskID=1785686
Ah, thanks! The normal procedure is for you to update the release field in the spec file, and post a link to the updated spec and srpm here. You haven't addressed the first issue yet (rm -rf %{buildroot}) Just a few more comments: - /usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/auto/Net/ARP/ARP.bs is an empty file and I don't think it's needed. - Rename the .spec to perl-Net-ARP.spec (with capitals R and P). The spec has to have the same name as the package. (rpmlint also complains about this when you run it on the src.rpm). - Why not make pure_install?
My mistake, I had changed the name of the spec but must have been after that version of the .src.rpm was built. I had originally used pure_install but had some errors, I can't remember what though. This time seemed fine so I have reverted to pure_install. I believe all above issues are now resolved. http://5dollarwhitebox.org/tmp/perl-Net-ARP.spec http://5dollarwhitebox.org/tmp/perl-Net-ARP-1.0.6-2.src.rpm [wdierkes@220805-mock00 perl-Net-ARP]$ rpmlint SPECS/perl-Net-ARP.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Thanks Ruben.
Thanks, everything looks fine now. This package is approved.
New Package CVS Request ======================= Package Name: perl-Net-ARP Short Description: Create and Send ARP Packets Owners: derks Branches: F-11 F-12 EL-5 InitialCC:
cvs done.