Bug 538260 - If user goes back, they are warned about the home directory -- should remember that just created
Summary: If user goes back, they are warned about the home directory -- should remembe...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: firstboot
Version: 14
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Martin Gracik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 538305 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-18 02:42 UTC by Denny Crane
Modified: 2013-07-04 12:47 UTC (History)
3 users (show)

Fixed In Version: firstboot-1.114-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-18 13:15:04 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Denny Crane 2009-11-18 02:42:17 UTC
Description of problem:
If the end-user creates a username, then uses the back button to return to a previous screen, then goes through the username screen a second time (as they are forced to do), they get a warning about the home directory already existing even though firstboot is the one that just created it. I believe that firstboot, while running, should remember what home directory or directories (as I imagine it is possible from this result to create multiple users by going back and forth) so that the user doesn't have the unpleasant experiencing of seeing a needless warning.

Version-Release number of selected component (if applicable):
1.110-1 / Fedora 12

How reproducible:
100%

Steps to Reproduce:
1.Create a user
2.Navigate back to the "Welcome" screen, for example
3.Attempt to navigate back through using "Next"
  
Actual results:
Warning / request for user decision when it is not necessary.

Expected results:
No warning / request for user decision when it is not necessary.


Additional info:

Comment 1 Aran 2009-11-22 09:21:30 UTC
*** Bug 538305 has been marked as a duplicate of this bug. ***

Comment 2 Bug Zapper 2010-11-04 06:14:49 UTC
This message is a reminder that Fedora 12 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 12.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '12'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 12's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 12 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Kamil Páral 2010-11-04 09:51:30 UTC
Still an issue with firstboot-1.113-4.fc14.x86_64.

Comment 4 Martin Gracik 2011-01-18 13:15:04 UTC
If you fill the same information in the create user screen, firstboot tries to create the user again, that's why you get the warning.

But I fixed the checking if you have a user available, so now, if you create a use and go back to the create user screen again, you should be able to leave all entries blank, and click next, without any warning. This is how it should work, if you already created the user, don't fill the information again, if you go back.

Comment 5 Kamil Páral 2011-01-18 14:37:30 UTC
mgracik, I don't exactly understand the change you made, but this bug report is about one thing only: It is a customary that a wizard makes all (substantial) changes after you press Finish, not before. That enables you to freely traverse back and forth (Previous and Next) in the wizard without problems. Moreover, it is again a custom that you can freely adjust a textfield (like change the Full (user) Name) without problems.

If any wizard fails these customs, it's generally regarded as user-unfriendly. This bug is exactly about failing these customs.

Of course, not always it is possible to adhere to these principles. But it should certainly be possible to hit Back, fix typo in my Full Name, and hit Forward again.

Comment 6 Martin Gracik 2011-01-18 15:14:04 UTC
Firstboot is not a standard wizard. It has dynamically loaded modules, which depend on the changes modules loaded before them make. So it cannot just wait till you go over all the pages, and then apply all changes at the end. I would like to do it this way, but I have to support 3rd party modules which will not work this way. Also, you can run other apps from inside it, like the system-config-users, which creates the user immediately, and firstboot then serves only as a place which allows you to run it. I have no control about what this other app is doing, so I cannot postpone it's application for later.

But what I could change is that when you click Back, the text entries won't be filled with the old data, but cleared out.

I would even go that far as removing the Back button, but I don't think many people would like that.

Comment 7 Kamil Páral 2011-01-18 15:59:01 UTC
(In reply to comment #6)
> But what I could change is that when you click Back, the text entries won't be
> filled with the old data, but cleared out.
> 
> I would even go that far as removing the Back button, but I don't think many
> people would like that.

I am afraid that the first option is confusing ("where is my data? damn program, it lost all my input, I have to re-type it again!") and the second one is annoying ("I've made a typo in my name, let me go back!").

I certainly understand how hard it can be to create a user-friendly program. Famous 80/20 issue. This bug (and my duplicate) is reported in good faith it will help improve the program. If the fix is too hard to implement, then, unfortunately, it's too hard to implement (should we close as WONTFIX?).

Comment 8 Martin Gracik 2011-01-18 16:35:25 UTC
(In reply to comment #7)
> I am afraid that the first option is confusing ("where is my data? damn
> program, it lost all my input, I have to re-type it again!") and the second one
> is annoying ("I've made a typo in my name, let me go back!").

The thing is that the data you entered are already applied, so it didn't lost it, if you fill out different data, you will end up with 2 users created, maybe we can explain this on the page, so you will know that after going forward, the data entered before will already be applied to your system, you cannot make changes, just additions.

> 
> I certainly understand how hard it can be to create a user-friendly program.
> Famous 80/20 issue. This bug (and my duplicate) is reported in good faith it
> will help improve the program. If the fix is too hard to implement, then,
> unfortunately, it's too hard to implement (should we close as WONTFIX?).

Comment 9 Kamil Páral 2011-01-18 16:48:31 UTC
(In reply to comment #8)
> The thing is that the data you entered are already applied, so it didn't lost
> it, if you fill out different data, you will end up with 2 users created, maybe
> we can explain this on the page, so you will know that after going forward, the
> data entered before will already be applied to your system, you cannot make
> changes, just additions.

Yes, I certainly understand that now. And the 99% of the rest of the users certainly don't have a clue :-)

At least informing them somehow would be great, thanks.

My idea: Don't make any changes to the default process (Next-Next-Next). But if the user hits Back, clear all the fields (Username, Full Name, etc), and display an infobox at the bottom of the page saying "1 user already created: <username>".

This way it's quite clear that you can't change the values you already confirmed, but you can create another user if you fill the blanks. It's certainly more obvious then presently. And it shouldn't be hard to implement.

Comment 10 Martin Gracik 2011-01-19 09:31:29 UTC
The only difficulty here is that you can create a user with system-config-user, using the Advanced button, bypassing the firstboot user creation code. So keeping track of users that have been created during firstboot execution is not trivial, but doable.


Note You need to log in before you can comment on or make changes to this bug.