Bug 538332 - Review Request: covered - Verilog code coverage analyzer
Summary: Review Request: covered - Verilog code coverage analyzer
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-11-18 09:52 UTC by Chitlesh GOORAH
Modified: 2009-11-24 19:43 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-11-24 19:43:56 UTC
Type: ---
Embargoed:
panemade: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Chitlesh GOORAH 2009-11-18 09:52:55 UTC
Spec URL: http://chitlesh.fedorapeople.org/RPMS/covered.spec
SRPM URL: http://chitlesh.fedorapeople.org/RPMS/covered-0.7.7-1.fc12.src.rpm
Description:
Covered is a Verilog code-coverage utility using VCD/LXT style dumpfiles
and the design to generate line, toggle, memory, combinational logic, 
FSM state/arc and assertion coverage reports. Covered also contains a 
built-in race condition checker and GUI report viewer.

Comment 1 Parag AN(पराग) 2009-11-20 07:15:58 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818896
+ rpmlint output for SRPM and for RPM.
covered.i686: E: explicit-lib-dependency tklib
covered.i686: W: hidden-file-or-dir /usr/share/covered/.coveredrc
==> can be ignored
+ source files match upstream url (sha1sum)
334783f26365d9c12c11773b48da790c45b51eb4  covered-0.7.7.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ gtk-update-icon-cache scriptlets present.
+ no duplicates in %files.
+ Desktop file installed correctly.
+ file permissions are appropriate.
+ Package covered-0.7.7-1.fc13.i686 =>
Provides: covered.cver.so covered.vpi
Requires: libX11.so.6 libXft.so.2 libXrender.so.1 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.11) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libdl.so.2 libfontconfig.so.1 libfreetype.so.6 libm.so.6 libm.so.6(GLIBC_2.1) libtcl8.5.so libtk8.5.so libz.so.1 rtld(GNU_HASH)
+ GUI application

Suggestions:
1) you can use Source URL as simple as
http://downloads.sourceforge.net/covered/covered-0.7.7.tar.gz
Reference:-http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
2) License should be GPLv2+

APPROVED.

Comment 2 Chitlesh GOORAH 2009-11-20 12:34:40 UTC
New Package CVS Request
=======================
Package Name: covered
Short Description: Verilog code coverage analyzer
Owners: chitlesh
Branches: F-11 F-12 EL-5

Comment 3 Dennis Gilmore 2009-11-20 21:54:23 UTC
CVS done


Note You need to log in before you can comment on or make changes to this bug.