Created attachment 370211 [details] Set the lirc socket correctly in sysconfig Description of problem: The NEWS file of lirc 0.8.6 (in Fedora >= 12) says "moved lircd socket from /dev/lircd to /var/run/lirc/lircd". The /etc/sysconfig/vdr settings should be changed accordingly. Currently the lirc support isn't working in F-12. I'll attach a packaging patch against devel, should apply in F-12 too. Even though I'm a co-maintainer for the package, I wanted to run this through Bugzilla for peer review.
Looks ok in principle, but I'd rather change the compiled in default - config file changes are hairy (noreplace issues etc). It seems to me that setting "LIRC_DEVICE = /var/run/lirc/lircd" in Make.config would do most of the trick, but PLUGINS/src/sky/sky.c and vdr.1 would need to be patched. Even better if this change could be done conditionally at build time by detecting if it's required from $somewhere (something in lirc-devel, maybe?) so we could still use the same specfile for many distro versions. Another alternative would be to do it dynamically at runtime, for example something like this in sysconfig: LIRC_SOCKET=/dev/lircd [ -e /var/run/lirc/lircd ] && LIRC_SOCKET=/var/run/lirc/lircd VDR_OPTIONS=(--lirc=$LIRC_SOCKET ...) ...but I think I'd still prefer changing the compiled in default. No strong opinions though. How does VDR behave if given a wrong/nonexistent LIRC socket path, refuses to start or stats but remote doesn't work? Hopefully the latter. (I no longer use LIRC with VDR.)
(In reply to comment #1) > How does VDR behave if given a wrong/nonexistent LIRC socket path, refuses to > start or stats but remote doesn't work? Hopefully the latter. (I no longer > use LIRC with VDR.) Starts, but the remote doesn't work. You have a valid point about the config changes, it's ok for me to change the compiled in default. I'd need to investigate a bit further if it's possible to detect the the lirc version at build time or something like that.
The lirc-devel package basically has one header file and a .so symlink. I don't think there's anything which the lirc version could be determined from.
Created attachment 372931 [details] Patch to vdr.spec for the lirc socket change
Created attachment 372932 [details] Patch to the sky plugin and the man page for the lirc socket change
I've attached patches for the spec file and for the sky plugin and the man page. The spec file patch may not necessarily apply for F12, but the changes can be easily made manually. Ville, could you check the patches and apply, if they're ok. I didn't want to apply them myself yet, especially since it seems you haven't tagged the RTLD_DEEPBIND release and that patch isn't even applied in the spec file.
Ohh, I've managed to fsck up the deepbind stuff, backed out for now, thanks for noticing. I applied a somewhat modified version of the patches to CVS/devel as -29 (not tagged yet): make patching conditional based on lirc-devel (rpm) version available, apply a generic patch to the sky plugin that makes it respect LIRC_DEVICE from Make.config, do man page modification with sed. If you're happy with these changes (and that they're still attributed to you), go ahead and tag and do the builds. I did a few local ones and they seemed ok.
vdr-1.6.0-29.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/vdr-1.6.0-29.fc12
Builds made, for Rawhide too.
vdr-1.6.0-29.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vdr'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12063
vdr-1.6.0-29.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.