Bug 541533 - Review Request: hunspell-si - Sinhala hunspell dictionaries
Review Request: hunspell-si - Sinhala hunspell dictionaries
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Caolan McNamara
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2009-11-26 03:57 EST by Parag Nemade
Modified: 2009-11-27 17:07 EST (History)
3 users (show)

See Also:
Fixed In Version: 0.2-1.fc12
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-11-27 01:49:05 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
caolanm: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Parag Nemade 2009-11-26 03:57:03 EST
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/hunspell-si.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/hunspell-si-0.2-1.fc12.src.rpm
Description: Sinhala hunspell dictionaries.
Comment 1 Caolan McNamara 2009-11-26 04:08:33 EST
Review:
+ package builds in mock.
 Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1831772
+ rpmlint is silent for SRPM and for RPM except for "Sinhala" not being in the US English dictionary
+ source files match upstream.
2bca6e63410493f9c70c1b594c55c661 sinhala_spellchecker-0.2-fx.xpi
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English except for "Sinhala" not being in the US English dictionary
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
- License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.

APPROVED.
Comment 2 Parag Nemade 2009-11-26 04:14:05 EST
Caolan thanks for quick review!

New Package CVS Request
=======================
Package Name: hunspell-si
Short Description: Sinhala hunspell dictionaries
Owners: pnemade
Branches: F-11 F-12
InitialCC:
Comment 3 Kevin Fenzi 2009-11-27 00:27:55 EST
cvs done.
Comment 4 Fedora Update System 2009-11-27 01:34:16 EST
hunspell-si-0.2-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/hunspell-si-0.2-1.fc11
Comment 5 Fedora Update System 2009-11-27 01:44:19 EST
hunspell-si-0.2-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/hunspell-si-0.2-1.fc12
Comment 6 Fedora Update System 2009-11-27 16:41:10 EST
hunspell-si-0.2-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 7 Fedora Update System 2009-11-27 17:06:59 EST
hunspell-si-0.2-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.