Bug 543599 - Failure to get polkit authorizations should be handled better
Summary: Failure to get polkit authorizations should be handled better
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: system-config-services
Version: 12
Hardware: i686
OS: Linux
low
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: abrt_hash:08997608
: 567770 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-02 17:37 UTC by thunt
Modified: 2010-03-22 18:31 UTC (History)
103 users (show)

Fixed In Version: system-config-services-0.99.43-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-20 03:48:36 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
File: backtrace (1.40 KB, text/plain)
2009-12-02 17:37 UTC, thunt
no flags Details

Description thunt 2009-12-02 17:37:10 UTC
abrt 1.0.0 detected a crash.

backtrace
-----
Summary: TB08997608 connection.py:630:call_blocking:DBusException: org.fedoraproject.slip.dbus.service.PolKit.NotAuthorizedException.org.fedoraproject.config.services.manage: 

Traceback (most recent call last):
  File "/usr/bin/system-config-services", line 873, in on_serviceEnable_activate
    service.enable()
  File "/usr/lib/python2.6/site-packages/scservices/dbus/proxy/services.py", line 77, in enable
    return self.chkconfig_interface.enable()
  File "/usr/lib/python2.6/site-packages/slip/dbus/proxies.py", line 49, in __call__
    return dbus.proxies._ProxyMethod.__call__(self, *args, **kwargs)
  File "/usr/lib/python2.6/site-packages/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/python2.6/site-packages/dbus/connection.py", line 630, in call_blocking
    message, timeout)
DBusException: org.fedoraproject.slip.dbus.service.PolKit.NotAuthorizedException.org.fedoraproject.config.services.manage: 

Local variables in innermost frame:
byte_arrays: False
self: <dbus._dbus.SystemBus (system) at 0x999441c>
args: ()
utf8_strings: False
bus_name: :1.173
get_args_opts: {'byte_arrays': False, 'utf8_strings': False}
object_path: /org/fedoraproject/Config/Services/ServiceHerders/SysVServiceHerder/Services/avahi_daemon
timeout: 2147483
signature: 
dbus_interface: org.fedoraproject.Config.Services.ChkconfigService
message: <dbus.lowlevel.MethodCallMessage object at 0x983d580>
method: enable

cmdline: /usr/bin/python /usr/bin/system-config-services 
component: system-config-services
executable: /usr/bin/system-config-services
kernel: 2.6.31.6-145.fc12.i686
package: system-config-services-0.99.41-1.fc12
uuid: 08997608

Comment 1 thunt 2009-12-02 17:37:11 UTC
Created attachment 375510 [details]
File: backtrace

Comment 2 David Radice 2009-12-10 09:00:22 UTC
Same problem here on x86-64.

Comment 3 Paul Lange 2009-12-10 23:15:19 UTC
Same for me.

Comment 4 Reinier Balt 2010-01-11 21:26:21 UTC
same here. No root authentication was asked

Comment 5 Nils Philippsen 2010-01-12 09:01:29 UTC
(In reply to comment #4)
> same here. No root authentication was asked

Your problem is a different one. This bug is about e.g. handling cancelled password dialogs. Please file a bug with a detailed description what you did and what happened. Thanks.

Comment 6 Reinier Balt 2010-01-12 09:11:03 UTC
could be, abrt pointed me to this bug report as duplicate. In my case not a cancelled password dialog, but nog dialog at all

Comment 7 David Radice 2010-01-12 09:22:16 UTC
(In reply to comment #6)
> could be, abrt pointed me to this bug report as duplicate. In my case not a
> cancelled password dialog, but nog dialog at all    

This also happened for me: no dialog at all. BTW system-config-services is now working for me since one of the last updates...

Comment 8 Nils Philippsen 2010-01-12 12:33:29 UTC
(In reply to comment #6)
> could be, abrt pointed me to this bug report as duplicate. In my case not a
> cancelled password dialog, but nog dialog at all    

Could be. Unfortunately abrt's duplicate detection bites us here -- the frontend can't distinguish between cancelled password dialogs and other problems so abrt thinks it's the same issue.

Comment 9 Yul Rottmann 2010-01-12 18:41:01 UTC
If there is no password dialog at all, do you use compiz? Here the password window always appears behind all other windows, so you can overlook the dialog easily. I searched for this bug, but couldn'd find any. Maybe you have the same problem?

Comment 10 Reinier Balt 2010-01-13 15:27:18 UTC
I use freenx. I do not see the dialog behind other windows. The problem remains running latest updates. Other system-config-tools are hit by the problem too.

I have some other crashes that are related to nx server not supporting xrandr.

Comment 11 Christopher Dix 2010-02-07 22:20:32 UTC
I have just re-installed Fedora 12, ran a yum update, and system-config-services crashed when I tried to run it from System -> Administration. As Reinier and David said, I too did not get any password dialog box. That doesn't mean that it wasn't _trying_ to load it, but the application crashed.

Comment 12 Christopher Dix 2010-02-07 22:37:32 UTC
(In reply to comment #11)
> I have just re-installed Fedora 12, ran a yum update, and
> system-config-services crashed when I tried to run it from System ->
> Administration. As Reinier and David said, I too did not get any password
> dialog box. That doesn't mean that it wasn't _trying_ to load it, but the
> application crashed.    

After restarting the computer, the services application functioned properly.

Comment 13 Nils Philippsen 2010-02-24 15:59:33 UTC
*** Bug 567770 has been marked as a duplicate of this bug. ***

Comment 14 Adam Williamson 2010-03-10 17:49:38 UTC

Comment
-----
I was just testing basic functions - starting and stopping services. It did seem to work okay, but also threw this exception.

Comment 15 Adam Williamson 2010-03-10 17:52:23 UTC
To give a more clear explanation since this one seems to be tricky: I'm on F13. Doing easy-karma, this update showed up in the list, so I went to test the app. I ran it, picked a service to try and stop (NetworkManager), hit Stop, and it prompted for root password. I realized I didn't really want to stop NM, so hit Cancel. Then I picked a different service (acpid), hit stop, entered the root password, and it stopped. Hit start, and it started.

At some point in the above process, the abrt alert showed up; I can't say exactly when. s-c-s did not actually crash or behave in any unexpected way at any point. It may have been when I hit Cancel on the authentication dialog for stopping NM?

Comment 16 Nils Philippsen 2010-03-11 09:10:34 UTC
(In reply to comment #15)
> At some point in the above process, the abrt alert showed up; I can't say
> exactly when. s-c-s did not actually crash or behave in any unexpected way at
> any point. It may have been when I hit Cancel on the authentication dialog for
> stopping NM?    

Very likely. I'm busy with other stuff so making this more cosmetically appealing isn't right on the top of my todo list... I think this should be caught in the python-slip dbus/polkit wrappers, but would need API amendments: it should eat the exception and return a value that signifies "failure" (or alternatively throws a custom "auth failed" exception that is caught by the GUI), and should let users of the API specify what exactly shall be returned/thrown in that case. The polkit.enable_proxy decorator doesn't accept parameters right now and adding that possibility without breaking existing apps isn't exactly trivial.

Comment 17 Fedora Update System 2010-03-11 15:15:06 UTC
system-config-services-0.99.43-1.fc12,python-slip-0.2.8-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/system-config-services-0.99.43-1.fc12,python-slip-0.2.8-1.fc12

Comment 18 Fedora Update System 2010-03-11 15:15:45 UTC
system-config-services-0.99.43-1.fc13,python-slip-0.2.8-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/system-config-services-0.99.43-1.fc13,python-slip-0.2.8-1.fc13

Comment 19 Adam Williamson 2010-03-11 21:59:16 UTC
Looks good. First I confirmed it was indeed after I hit Cancel that it threw the exception. Then I updated to the newer packages in comment #18 and re-tested; no abrt icon. Thanks.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 20 Markus Schulze 2010-03-12 14:53:49 UTC

Comment
-----
I tried to restart xinet.d service

Comment 21 Fedora Update System 2010-03-13 02:30:49 UTC
system-config-services-0.99.43-1.fc12, python-slip-0.2.8-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-services python-slip'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/system-config-services-0.99.43-1.fc12,python-slip-0.2.8-1.fc12

Comment 22 luigi votta 2010-03-17 16:31:35 UTC

Comment
-----
It happens casually: sometimes when starting a service, sometimes when trying to restart it (the service was libvirtd).

Comment 23 luigi votta 2010-03-17 16:54:26 UTC
Updated as suggested in comment #18 or #21

Thank You

Comment 24 Aioanei Rares 2010-03-17 19:24:42 UTC

How to reproduce
-----
1.start s-c-s from command line as normal user
2.
3.

Comment 25 Adam Williamson 2010-03-17 20:50:03 UTC
can people who are reporting this now please try the candidate update? as I said, it fixes the problem fine for me.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 26 Fedora Update System 2010-03-20 03:37:35 UTC
system-config-services-0.99.43-1.fc13, python-slip-0.2.8-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 27 Fedora Update System 2010-03-20 03:48:30 UTC
system-config-services-0.99.43-1.fc12, python-slip-0.2.8-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.