Spec URL: http://repo.calcforge.org/f13/kpilot.spec SRPM URL: http://repo.calcforge.org/f13/kpilot-5.3.0-1.fc13.src.rpm Description: Utility to synchronize PIM (Personal Information Management) data with PalmOS devices. This package was part of kdepim until 4.3.4. It is being dropped from kdepim 4.4, so I'm packaging it as a standalone package, based on the last kdepim release which carried it (4.3.4). dist-f13 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1874593
rdieter said he'll do the review.
I'll look at this today, sure (perhaps swap reviews for bug #547916 )
rpmlint: kpilot.src: E: summary-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices kpilot.src: E: description-line-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices. $ rpmlint *src.rpm x86_64/*.rpm kpilot.src: E: summary-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices kpilot.src: E: description-line-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices. error checking signature of kpilot-5.3.0-1.fc13.src.rpm kpilot.x86_64: E: summary-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices kpilot.x86_64: E: description-line-too-long Utility to synchronize PIM (Personal Information Management) data with PalmOS devices. kpilot.x86_64: E: invalid-soname /usr/lib64/libkpilot_akonadibase.so libkpilot_akonadibase.so kpilot.x86_64: E: invalid-soname /usr/lib64/libkpilot_conduit_base.so libkpilot_conduit_base.so 3 packages and 0 specfiles checked; 6 errors, 0 warnings. Summary is longish, perhaps omit the "Utility to" part at the beginning? sources: ok a4f32a268802be8eb852d1de00cbd2f6 kdepim-4.3.4.tar.bz2 license: ok scriptlets: ok deps: ok Suggestions (consider these SHOULD items, can be addressed post-review): 1. make -libs package to be more multilib friendly 2. Add (something like): %if 0%{?fedora} < 13 Conflicts: kdepim < 6:4.3.80 %endif Otherwise, looks good, APPROVED.
Uh, KPilot is an application, why would you want to install it multilib?
You don't, but... anything matching %{_libdir}/lib*.so.* is automatically multilib'd, for better or worse.
But multilibs aren't installed by default unless some 32-bit apps drags them in. If someone tweaks their yum configuration to install everything multilib, they get what they deserve. ;-) Anyway, I can add a -libs subpackage if you really think it's useful.
I think -libs is best, avoids possible multilib conflicts that way.
New Package CVS Request ======================= Package Name: kpilot Short Description: Sync PIM data with PalmOS devices Owners: kkofler than rdieter ltinkl jreznik arbiter mathstuf Branches: F-11 F-12 InitialCC: tuxbrewr (I'll address the suggested improvements after importing.)
cvs done.