Spec URL: http://www.krisbuytaert.be/download/djagios.spec SRPM URL: http://www.krisbuytaert.be/download/djagios-0.1.3-1.src.rpm Description: Djagios is an open source Nagios web based configuration tool with a complete Py thon Nagios API. The main goal of the tool was to make Nagios usable for non-Nagios admins. The i nitial install and configuration would have to be done by Nagios administrators. But once done ordinary users can add servers, appliances, devices, services the mselves. Note: This is my first package !
Just some quick comments on your spec file. Please check your files with rpmlint. [fab@localhost SRPMS]$ rpmlint djagios-0.1.3-1.src.rpm djagios.src: W: summary-ended-with-dot Djagios is an open source Nagios web based configuration tool with a complete Python Nagios API.. djagios.src: E: summary-too-long Djagios is an open source Nagios web based configuration tool with a complete Python Nagios API.. djagios.src: W: name-repeated-in-summary Djagios djagios.src: E: description-line-too-long Djagios is an open source Nagios web based configuration tool with a complete Python Nagios API. djagios.src: E: description-line-too-long The main goal of the tool was to make Nagios usable for non-Nagios admins. The initial install and configuration would have to be done by Nagios administrators. But once done ordinary users can add servers, appliances, devices, services themselves. djagios.src: W: no-version-in-last-changelog 1 packages and 0 specfiles checked; 3 errors, 3 warnings. - Please replace '%define' with '%global' according to the Packaging Guidelines http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define - You must use macros. http://fedoraproject.org/wiki/How_to_create_an_RPM_package#Macros
(In reply to comment #1) Running rpmlint on the specfile rather than the src rpm apparently wasn't my smartest move . Rpmlint issues are gone. I've replaced all %defines with %global But I guess I need some more detail on where you want me to use macro's.. Thnx for the feedback !
(In reply to comment #2) >(In reply to comment #1) > But I guess I need some more detail on where you want me to use macro's.. Here '/usr/share/djagios-0.1/' Your are defining in the head of the file '%global djagiosdir %{_datadir}/djagios'. I think this is not needed. At least I can see where it's used. A empty line between the changelog entries would be nice. You will see that those entries will be parsed to a website and with a blank line it's easier to ready.
I've updated the whitespace , and Used and replaced the %djagiosdir with the correct path. thnx in advance for your comments !
Can you please the updated files (spec and SRPM)?
Files are up2date on http://www.krisbuytaert.be/download/djagios-0.1.3-1.src.rpm http://www.krisbuytaert.be/download/djagios.spec
did you try building via mock --rebuild ? You should include BuildRequires: python2-devel in your spec -file After including BuildRequires in spec file, rpmbuild -ba djagios.spec gives me (mock too): BUILDROOT/djagios-0.1.3-1.fc12.i386 error: Installed (but unpackaged) file(s) found: /usr/lib/python2.6/site-packages/djagios-0.1.3-py2.6.egg-info
Although it is minor, please change the summary and remove "Djagios is an open source". "Foo is ..." is redundant and all our packages are FOSS.
Hey Kris, are you still interested in joining the Fedora package maintainers? The last comments here are 3 months old not have not been answered by you. Did you perform some unofficial reviews? If you are not interested anymore or are just lacking the time currently, please let us know.
No response in half a year; closing.