Spec URL: http://akurtakov.fedorapeople.org/plexus-interpolation.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-interpolation-1.13-1.fc12.src.rpm Description: Plexus interpolator is the outgrowth of multiple iterations of development focused on providing a more modular, flexible interpolation framework for the expression language style commonly seen in Maven, Plexus, and other related projects.
Good: - builds - source good (no diffs in my checkout vs. yours packed in the tarball) - macros fine - no pre-build JARs - files fine - clean present Needs work: - line length too long for %description - should probably get some %doc files - license should be ASL 2.0 and ASL 1.1 and MIT - rpmlint output is not clean: $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/plexus-interpolation-1.13-1.fc12.noarch.rpm plexus-interpolation.noarch: E: description-line-too-long Plexus interpolator is the outgrowth of multiple iterations of development focused on plexus-interpolation.noarch: E: description-line-too-long providing a more modular, flexible interpolation framework for the expression language plexus-interpolation.noarch: W: incoherent-version-in-changelog 1.8-1 ['1.13-1.fc12', '1.13-1'] plexus-interpolation.noarch: W: no-documentation plexus-interpolation.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-interpolation 1 packages and 0 specfiles checked; 2 errors, 3 warnings. $ rpmlint /home/overholt/rpmbuild/SRPMS/plexus-interpolation-1.13-1.fc12.src.rpm plexus-interpolation.src: E: description-line-too-long Plexus interpolator is the outgrowth of multiple iterations of development focused on plexus-interpolation.src: E: description-line-too-long providing a more modular, flexible interpolation framework for the expression language 1 packages and 0 specfiles checked; 2 errors, 0 warnings. $ rpmlint /home/overholt/rpmbuild/RPMS/noarch/plexus-interpolation-javadoc-1.13-1.fc12.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
(In reply to comment #1) > Good: > - builds > - source good (no diffs in my checkout vs. yours packed in the tarball) > - macros fine > - no pre-build JARs > - files fine > - clean present > > Needs work: > > - line length too long for %description Fixed. > - should probably get some %doc files There is nothing suitable. > - license should be ASL 2.0 and ASL 1.1 and MIT Fixed. > - rpmlint output is not clean: > Output now is but both are fase positives.: plexus-interpolation.noarch: W: no-documentation plexus-interpolation.noarch: W: non-conffile-in-etc /etc/maven/fragments/plexus-interpolation New sources: Spec URL: http://akurtakov.fedorapeople.org/plexus-interpolation.spec SRPM URL: http://akurtakov.fedorapeople.org/plexus-interpolation-1.13-2.fc12.src.rpm
Okay, thanks for the fixes. Approved.
New Package CVS Request ======================= Package Name: plexus-interpolation Short Description: Plexus Interpolation API Owners: akurtakov Branches: InitialCC:
CVS Done
Built in rawhide. http://koji.fedoraproject.org/koji/buildinfo?buildID=148398