Bug 550067 - Review Request: perl-Template-Tiny - Template Toolkit reimplemented in as little code as possible
Summary: Review Request: perl-Template-Tiny - Template Toolkit reimplemented in as lit...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Emmanuel Seyman
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-12-23 13:34 UTC by Marcela Mašláňová
Modified: 2010-02-11 14:39 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-11 14:39:09 UTC
Type: ---
Embargoed:
emmanuel: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Marcela Mašláňová 2009-12-23 13:34:24 UTC
Spec URL: http://mmaslano.fedorapeople.org/review/perl-Template-Tiny.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Template-Tiny-0.09-1.fc13.src.rpm
Description: WARNING: THIS MODULE IS EXPERIMENTAL AND SUBJECT TO CHANGE WITHOUT NOTICE Template::Tiny is a reimplementation of a partial subset of the Template Toolkit,  in as few lines of code as possible. It is intended for use in light-usage, low-memory, or low-cpu templating situations, where you may need to upgrade to the full feature set 
in the future, or if you want the familiarity of TT-style templates. It is intended to have fully-compatible template and stash usage, with a limited by similar Perl API. Unlike Template Toolkit, Template::Tiny will process templates without a compile phase  (but despite this is still quicker, owing to heavy use of the Perl regular expression engine.

Comment 1 Mamoru TASAKA 2010-01-24 17:14:19 UTC
(The submitter must not set fedora-review flag.
 This is to be set by the reviewer.)

Comment 2 Philip Prindeville 2010-01-26 17:24:51 UTC
Please add:

link to Koji build.

output from rpmlint on the .spec and .src.rpm files.

Comment 3 Marcela Mašláňová 2010-01-27 06:58:54 UTC
(In reply to comment #2)
> Please add:
> 
> link to Koji build.
> 
> output from rpmlint on the .spec and .src.rpm files.    

Reviewer must run rpmlint for himself, also koji build can't be old. In other case I could do review for myself.

Comment 4 Emmanuel Seyman 2010-01-30 08:00:25 UTC
Haven't finished review yet but I've stumbled on a couple of problems.

- The version packaged is 0.09 but 0.10 is the latest available.
Please update the package or give a compelling reason for staying on 0.09.

- rpmlint gives the following output on the .src.rpm :

perl-Template-Tiny.src: E: description-line-too-long Template::Tiny is a reimplementation of a partial subset of the Template Toolkit,
perl-Template-Tiny.src: E: description-line-too-long in as few lines of code as possible. It is intended for use in light-usage, low-memory,
perl-Template-Tiny.src: E: description-line-too-long or low-cpu templating situations, where you may need to upgrade to the full feature set
perl-Template-Tiny.src: E: description-line-too-long in the future, or if you want the familiarity of TT-style templates. It is intended to
perl-Template-Tiny.src: E: description-line-too-long have fully-compatible template and stash usage, with a limited by similar Perl API.
perl-Template-Tiny.src: E: description-line-too-long Unlike Template Toolkit, Template::Tiny will process templates without a compile phase
perl-Template-Tiny.src: E: description-line-too-long (but despite this is still quicker, owing to heavy use of the Perl regular expression engine.

Please fix the description.

The spec file (and META.yaml) say this module requires Test::More but I'm not saying this in the code. Everything else looks fine but I'ld rather hold off review until the above two items are fixed.

FAIL.

Comment 5 Philip Prindeville 2010-01-30 19:06:18 UTC
(In reply to comment #4)
> Haven't finished review yet but I've stumbled on a couple of problems.
> 
> [...] 
> The spec file (and META.yaml) say this module requires Test::More but I'm not
> saying this in the code. Everything else looks fine but I'ld rather hold off
> review until the above two items are fixed.
> 
> FAIL.    

Look in Makefile.PL and in t/*.t ... that's the test suite.  You'll see that it's used there.

Comment 6 Emmanuel Seyman 2010-01-30 19:30:53 UTC
(In reply to comment #5)
> 
> Look in Makefile.PL and in t/*.t ... that's the test suite.  You'll see that
> it's used there.

That explains having perl(Test::More) in the BuildRequires but not why it is in Requires.

Comment 7 Philip Prindeville 2010-01-30 19:47:49 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > 
> > Look in Makefile.PL and in t/*.t ... that's the test suite.  You'll see that
> > it's used there.
> 
> That explains having perl(Test::More) in the BuildRequires but not why it is in
> Requires.    

Well, maybe cpanspec is broken and is generating incorrect output.

Comment 8 Emmanuel Seyman 2010-01-30 22:22:42 UTC
(In reply to comment #7)
>
> Well, maybe cpanspec is broken and is generating incorrect output.    

cpanspec reads a module's META.yml to generate BuildRequires and Requires.
If the META.yml is incorrect, cpanspec's output will be incorrect.

Comment 10 Emmanuel Seyman 2010-02-01 23:59:50 UTC
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=1957451
 [x] Rpmlint output: 2 packages and 1 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable.
 [x] Buildroot is correct
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
d2285afd5d2fad99bc28239e27b93360  Template-Tiny-0.10.tar.gz
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: fedora-rawhide-x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: fedora-rawhide-x86_64
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=7, Tests=56,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.15 cusr  0.03 csys =  0.22 CPU)
Result: PASS

Note that "limited by similar" should probably read "limited but similar".

APPROVED.

Comment 11 Marcela Mašláňová 2010-02-04 08:50:36 UTC
Upstream is from Australia, so I'd rather leave it as it is.

Thank you for your review.

Comment 12 Emmanuel Seyman 2010-02-07 09:04:00 UTC
Note that if you're requesting the creation of a CVS module, you'll need to add the needed details. See the wiki page for details:
https://fedoraproject.org/wiki/CVS_admin_requests

Comment 13 Jason Tibbitts 2010-02-09 21:04:00 UTC
Since there's no CVS request here; I'll clear the flag.
Please set it back when you file an actual CVS request.

Comment 14 Marcela Mašláňová 2010-02-10 06:36:24 UTC
New Package CVS Request
=======================
Package Name: perl-Template-Tiny
Short Description: Template Toolkit reimplemented in as little code as possible
Owners: mmaslano
Branches: 
InitialCC: perl-sig

Comment 15 Kevin Fenzi 2010-02-11 06:06:34 UTC
CVS done (by process-cvs-requests.py).


Note You need to log in before you can comment on or make changes to this bug.