Bug 552557 - Merge Review: perl-Config-Tiny - Perl module for reading and writing .ini style configuration files
Summary: Merge Review: perl-Config-Tiny - Perl module for reading and writing .ini sty...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-01-05 14:28 UTC by Marcela Mašláňová
Modified: 2010-04-28 04:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-15 11:53:45 UTC
Type: ---
Embargoed:
panemade: fedora-review+


Attachments (Terms of Use)

Description Marcela Mašláňová 2010-01-05 14:28:53 UTC
SRPM: http://kojipkgs.fedoraproject.org/packages/perl-Config-Tiny/2.12/7.fc12/src/perl-Config-Tiny-2.12-7.fc12.src.rpm
Spec: http://koji.fedoraproject.org/koji/fileinfo?rpmID=1422538&filename=perl-Config-Tiny.spec
Description: 
Config::Tiny is a Perl module designed for reading and writing .ini style configuration files. It is designed for simplicity and ease of use, and thus only supports the most basic operations.

Comment 1 Parag AN(पराग) 2010-01-15 06:52:27 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1923052
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
45360fdf2bd263fdb090d833a09ba3bc7e8578f8  Config-Tiny-2.12.tar.gz
+ package meets naming and packaging guidelines.
+ make test gave
All tests successful.
Files=4, Tests=36,  0 wallclock secs ( 0.02 usr  0.01 sys +  0.18 cusr  0.04 csys =  0.25 CPU)
+ Package perl-Config-Tiny-2.12-7.fc13.noarch =>
Provides: perl(Config::Tiny) = 2.12
Requires: perl(strict)

Suggestions
1)change line
chmod -R u+w $RPM_BUILD_ROOT/*
to
%{_fixperms} $RPM_BUILD_ROOT/*

APPROVED.

Comment 2 Marcela Mašláňová 2010-01-15 11:53:45 UTC
Thanks, changed.

Comment 3 Fedora Update System 2010-04-28 04:35:15 UTC
kernel-2.6.32.12-114.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/kernel-2.6.32.12-114.fc12


Note You need to log in before you can comment on or make changes to this bug.