Bug 55713 - prints wrong values for Disposal method and Color Resolution
Summary: prints wrong values for Disposal method and Color Resolution
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: giftrans
Version: 7.2
Hardware: i686
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Phil Knirsch
QA Contact:
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2001-11-05 15:38 UTC by Asko Tontti
Modified: 2015-03-05 01:09 UTC (History)
1 user (show)

(edit)
Clone Of:
(edit)
Last Closed: 2001-11-05 15:40:52 UTC


Attachments (Terms of Use)
fix for the bug. Use parentheses to fix operator precedence errors (1.05 KB, patch)
2001-11-05 15:40 UTC, Asko Tontti
no flags Details | Diff

Description Asko Tontti 2001-11-05 15:38:17 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5+) Gecko/20011104

Description of problem:
The source code of giftrans has C operator precedence errors which
cause wrong values to be used when printing "Disposal method" and
"Color Resolution".

I have a patch for this bug.

Version-Release number of selected component (if applicable):
  giftrans-1.12.2-9


How reproducible:
Always

Steps to Reproduce:
1. giftrans -L harrycanuck.gif |& grep -i method


Actual Results:
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 5 (to be defined)


Expected Results:
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)
        Disposal Method: 2 (restore to background color)
        Disposal Method: 1 (do not dispose)


Additional info:

Take (or create with GIMP) any animated GIF with different disposal
methods to test.

Comment 1 Asko Tontti 2001-11-05 15:40:47 UTC
Created attachment 36462 [details]
fix for the bug. Use parentheses to fix operator precedence errors

Comment 2 Phil Knirsch 2001-11-06 15:42:22 UTC
Fixed in rawhide, version giftrans-1.12.2-10

Read ya, Phil




Note You need to log in before you can comment on or make changes to this bug.