Spec URL: http://declera.com/~yaneti/fontaine/fontaine.spec SRPM URL: http://declera.com/~yaneti/fontaine/fontaine-0-1.svn35.fc13.src.rpm Description: Fontaine is a command-line utility that displays key meta information about font files, including but not limited to font name, style, weight, glyph count, character count, copyright, license information and orthographic coverage. It is based on freetype. There are no official releases of fontaine. The most one can guess about the authors intentions of versioning can be found in CMakeLists.txt SET(FONTAINE_VERSION_MAJOR 1) SET(FONTAINE_VERSION_MINOR 0) but I think until an official release is made our best policy would be to stay with 0 as version number. This review request is partly just for documentation purposes. I thought the utility looked useful and made a package just to test it. I'll be glad to retire this review request if a new one from someone more eager to maintain it comes along. Feel free to peruse the provided spec.
The main issue with fontaine is it was developped in parallel of fontconfig instead of re-using it as much as possible. Not sure therefore if fontaine and fontconfig agree all the time :( However it's probably a good tool to have anyway (we probably need to package http://code.google.com/p/ots/ too)
Behdad: what do you think of fontaine at this stage?
I'm going to check the functionality and add the useful bits to fontconfig, but as you said, good to have it packaged anyway. ots, not so sure, but then again, can't hurt :).
Just gave it a quick spin (rpmlint looks clean:) http://koji.fedoraproject.org/koji/taskinfo?taskID=1959894
waiting for nim-nim for his comment....
If Behdad is ok with fontaine I'm fine with it. Do not forget to declare it in the fonts-design comps group. ots is a separate app, was just trying to enroll packagers :)
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1959894 + rpmlint is silent for SRPM and for RPM. + source files match upstream url + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application NOTE:- I tried to see if translations are working or not but have not got any success when I ran ============================================================ LANG=zh_CN.UTF-8 /usr/bin/fontaine -h Fontaine Version 1.0 alpha Copyright ⓒ 2009 by Edward H. Trager. All Rights Reserved. Released under GPL v. 2 or later. http://www.unifont.org ============================================================== I think above license text is translated but not worked for me. APPROVED.
(In reply to comment #7) > NOTE:- > I tried to see if translations are working or not but have not got any > success when I ran > ============================================================ > LANG=zh_CN.UTF-8 /usr/bin/fontaine -h > > Fontaine > Version 1.0 alpha > Copyright ⓒ 2009 by Edward H. Trager. All Rights Reserved. Released under GPL > v. 2 or later. > http://www.unifont.org > ============================================================== > I think above license text is translated but not worked for me. The original msgstr lost a space sometime after those translations were made. As A whole the program would benefit from some i18n love, I see a few messages not even included for translation. I'll leave this to upstream for now, no point in patching just for this particular copyright string. New Package CVS Request ======================= Package Name: fontaine Short Description: Font file meta information utility Owners: yaneti Branches: F-12 InitialCC:
added fonts-sig to cc CVS done (by process-cvs-requests.py).
Imported. Built. Bodhi update pushed. Thanks for the review. Anyone keen to co-maintain or own please apply in pkgdb.