Spec URL: http://chdorblog.free.fr/vifm.spec SRPM URL: http://chdorblog.free.fr/vifm-0.5-1.fc12.src.rpm Description: A ncurses based CLI file manager with vi like keybindings [chdorb@chdorb-desktop rpmbuild]$ rpmlint SRPMS/vifm-0.5-1.fc12.src.rpm \ > RPMS/i686/vifm-0.5-1.fc12.i686.rpm \ > RPMS/i686/vifm-debuginfo-0.5-1.fc12.i686.rpm \ > SPECS/vifm.spec 3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Hi I packaged up my second package vifm, please review. I also need a sponsor for this and ciso (bug #524423).
Some notes: ! BuildRoot - BuildRoot is no longer needed for Fedora (rpmlint may complain, however it can be ignored) https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Timestamps - Please consider to use ---------------------------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ---------------------------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. ! Documents ! Usually INSTALL file is for people trying to compile and install software by themselves and is not needed for people using rpm, however for this package I will leave it to how you think whether INSTALL file should be packaged or not. * Directory ownership issue https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes - The directory %{_datadir}/%{name} itself is not owned by any packages. * Source codes themselves - Some codes hardcode /usr/local for installed paths. ! For example from config.c: --------------------------------------------------------------------------------- 19 #define CP_HELP "cp /usr/local/share/vifm/vifm-help.txt ~/.vifm" 20 #define CP_RC "cp /usr/local/share/vifm/vifmrc ~/.vifm" --------------------------------------------------------------------------------- With this, launching vifm causes warnings like: --------------------------------------------------------------------------------- env LANG=C vifm cp /usr/local/share/vifm/vifm-help.txt ~/.vifmcp: cannot stat `/usr/local/share/vifm/vifm-help.txt': No such file or directory Unable to find configuration file. Using defaults.cp: cannot stat `/usr/local/share/vifm/vifmrc': No such file or directory --------------------------------------------------------------------------------- This needs fixing. - config.c reads: --------------------------------------------------------------------------------- 144 if(chdir(cfg.config_dir)) 145 { 146 if(mkdir(cfg.config_dir, 0777)) 147 return; 148 if(mkdir(cfg.trash_dir, 0777)) 149 return; 150 if((f = fopen(help_file, "r")) == NULL) 151 create_help_file(); 152 if((f = fopen(rc_file, "r")) == NULL) 153 create_rc_file(); 154 } --------------------------------------------------------------------------------- Here "0700" is much safer.
Created attachment 406015 [details] Patch to fix source code (comment 2)
Thank you. I've updated spec file and created a patch to fix source code. Spec URL: http://chdorblog.free.fr/vifm.spec SRPM URL: http://chdorblog.free.fr/vifm-0.5-2.fc12.src.rpm
[chdorb@chdorb-desktop rpmbuild]$ rpmlint SRPMS/vifm-0.5-2.fc12.src.rpm \ > RPMS/i686/vifm-0.5-2.fc12.i686.rpm \ > RPMS/i686/vifm-debuginfo-0.5-2.fc12.i686.rpm \ > SPECS/vifm.spec vifm.src: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses vifm.src: W: no-buildroot-tag vifm.i686: W: spelling-error %description -l en_US ncurses -> nurses, curses, n curses SPECS/vifm.spec: W: no-buildroot-tag 3 packages and 1 specfiles checked; 0 errors, 4 warnings.
For -2: One thing * Duplicate file entry - Now build.log shows: ------------------------------------------------------------- 268 warning: File listed twice: /usr/share/vifm/vifm-help.txt 269 warning: File listed twice: /usr/share/vifm/vifm.txt 270 warning: File listed twice: /usr/share/vifm/vifm.vim ------------------------------------------------------------- Please make it sure that every file is listed only once. ! Note: - The following %files entry ------------------------------------------------------------- %files %{_datadir}/%{name} ------------------------------------------------------------- contains the directory %{_datadir}/%{name} _and_ all files/directories/etc under this directory, while ------------------------------------------------------------- %files %dir %{_datadir}/%{name} ------------------------------------------------------------- contains the directory %{_datadir}/%{name} only.
One more thing * %changelog - It is better that you put one line between each %changelog entry like: ----------------------------------------------------------- %changelog * Mon Apr 12 2010 Pierre Dorbais <pierre.dorbais> 0.5-2 - Add INSTALL variable to make - Add patch Patch0 - Add missing path to files macro - Remove INSTALL doc file - Remove BuildRoot tag * Mon Feb 08 2010 Pierre Dorbais <pierre.dorbais> 0.5-1 - Initial RPM release ----------------------------------------------------------- Especially this is useful on Fedora CVS.
Done
Would you post your new spec / srpm ?
Ho sorry :s Spec URL: http://chdorblog.free.fr/vifm.spec SRPM URL: http://chdorblog.free.fr/vifm-0.5-3.fc12.src.rpm
Well, - This package is now in good shape - Your another review request (bug 524423) is perhaps in good shape to some extent at least (I will check it later) ----------------------------------------------------- This package (vifm) is APPROVED by mtasaka ------------------------------------------------------ Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Install the Client Tools (Koji)". Now I am sponsoring you. If you want to import this package into Fedora 11/12/13, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. Removing NEEDSPONSOR.
Thank you very much for help and sponsor me !
New Package CVS Request ======================= Package Name: vifm Short Description: Lightweight file manager with vi like key-bindings Owners: chdorb Branches: F-11 F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
vifm-0.5-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/vifm-0.5-3.fc11
Please build also for F-12/13 (and submit push requests on bodhi)
vifm-0.5-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update vifm'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/vifm-0.5-3.fc11
vifm-0.5-3.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/vifm-0.5-3.fc12
vifm-0.5-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/vifm-0.5-3.fc13
I wanted to view all the process for F-11 to be sure I am right before build and push for F-12/F-13. It's now also done for F-12 and F-13.
Closing.