Bug 563090 - config for daemon initscript missing
Summary: config for daemon initscript missing
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: transmission
Version: 11
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Rahul Sundaram
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-09 07:48 UTC by Pavol Šimo
Modified: 2010-02-17 06:41 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-17 06:41:08 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Pavol Šimo 2010-02-09 07:48:01 UTC
Description of problem:
the initscript /etc/rc.d/init.d/transmission-daemon contains this line:
# config: /etc/sysconfig/transmission
but the script never reads the config and the config file is not in the package

Version-Release number of selected component (if applicable):
transmission-daemon-1.83-1.fc11.x86_64

Additional info:
apply this patch, please

--- /etc/rc.d/init.d/transmission-daemon.orig    2010-02-09 08:35:09.000000000 +0100
+++ /etc/rc.d/init.d/transmission-daemon 2010-02-09 08:34:05.000000000 +0100
@@ -22,6 +22,9 @@
 DAEMON_USER="transmission"
 DAEMON_ARGS="-T --blocklist -g $TRANSMISSION_HOME/.config/transmission"

+# Config overrides
+[ -f /etc/sysconfig/transmission-daemon ] && . /etc/sysconfig/transmission-daemon
+
 # Daemon
 NAME=transmission-daemon

Comment 1 Rahul Sundaram 2010-02-09 08:12:24 UTC
instead of a empty file in /etc/sysconfig it would be more useful to provide a few commented out examples that show users what they could change  What would you want to change typically?

Comment 2 Pavol Šimo 2010-02-10 13:16:49 UTC
This is my /etc/sysconfig/transmission-daemon file:

TRANSMISSION_HOME=/home/palos
DAEMON_USER="palos"
DAEMON_ARGS="-T --blocklist -g $TRANSMISSION_HOME/.config/transmission-daemon"

It has these settings because I've used transmission-daemon from this account before and I was lazy to migrate the config...

So perhaps a little more commented default config would be useful ;-)

Comment 3 Rahul Sundaram 2010-02-10 17:01:58 UTC
Thanks for the patch and the example  I have committed it and pushed builds for Rawhide F-12 and F-11  Once the builds are done  I will push them to updates testing repo and then later to updates repo  You will get notifications from the update system when it is available in the updates testing repo  I recommend that you test it and provide your feedback early

Comment 4 Fedora Update System 2010-02-11 05:48:04 UTC
transmission-1.83-3.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/transmission-1.83-3.fc12

Comment 5 Fedora Update System 2010-02-11 05:49:19 UTC
transmission-1.83-3.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/transmission-1.83-3.fc11

Comment 6 Pavol Šimo 2010-02-11 13:06:29 UTC
There is one extra linebreak in the initscript. This must be on one line:

[ -f /etc/sysconfig/transmission-daemon ] && . /etc/sysconfig/transmission-daemon

(probably bugzilla broke the line - next time I post the patch as attachment...)

And in the configuration file should be presented default values from the initscript - what do you think?

Thank you

Comment 7 Rahul Sundaram 2010-02-11 13:56:10 UTC
How about the following?

if [ -f /etc/sysconfig/transmission-daemon ]; then
        . /etc/sysconfig/transmission-daemon
fi



Configuration file is merely an example and it doesn't matter much what the commented out values are

Comment 8 Pavol Šimo 2010-02-11 21:54:09 UTC
Yes, the script can be specified this way. Thanks

Comment 9 Fedora Update System 2010-02-12 04:47:33 UTC
transmission-1.83-3.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update transmission'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1802

Comment 10 Fedora Update System 2010-02-12 04:48:21 UTC
transmission-1.83-3.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update transmission'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1805

Comment 11 Pavol Šimo 2010-02-12 07:08:38 UTC
transmission-daemon-1.83-3.fc11 from updates-testing has the error in its initscript, see comment#6

Comment 12 Rahul Sundaram 2010-02-12 09:30:02 UTC
Yes the push was done before your followup comments  Upstream has informed me that 90 release is going to be available in a week that fixes a number of problems and I am going to be pushing the fix for this issue along with that release

Comment 13 Rahul Sundaram 2010-02-16 19:40:23 UTC
Build with fix for Rawhide

http://koji.fedoraproject.org/koji/taskinfo?taskID=1991622

Updates to Fedora 12 and Fedora 11 will follow soon

Comment 14 Rahul Sundaram 2010-02-17 06:41:08 UTC
Build for F-12 and F-11

https://admin.fedoraproject.org/updates/transmission-1.90-1.fc11


Note You need to log in before you can comment on or make changes to this bug.