Spec URL: http://www.informatik.uni-bremen.de/~fabiand/fedora/elliptics/1/elliptics.spec SRPM URL: http://www.informatik.uni-bremen.de/~fabiand/fedora/elliptics/1/elliptics-2.6.4-1.fc14.src.rpm Description: Elliptics network/dnet is a fault tolerant distributed hash table object storage. This package includes an example ioserver and a FastCGI interface. Note: Future versions of POHMELFS will be using elliptics/dnet.
[fabiand@proprietary rpmbuild]$ rpmlint -v SPECS/elliptics.spec SRPMS/elliptics-2.6.4-1.fc14.src.rpm RPMS/i686/elliptics-* SPECS/elliptics.spec: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.6.4.tar.gz (timeout 10 seconds) elliptics.src: I: checking elliptics.src: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.src: W: spelling-error %description -l en_US ioserver -> observer, timeserver, servery elliptics.src: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.src: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.6.4.tar.gz (timeout 10 seconds) elliptics.i686: I: checking elliptics.i686: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.i686: W: spelling-error %description -l en_US ioserver -> observer, timeserver, servery elliptics.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-debuginfo.i686: I: checking elliptics-debuginfo.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.i686: I: checking elliptics-devel.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 4 warnings. spelling-error: Nope. dnet is correct.
What might be a bit confusing is the naming of the project and package. I chose to use elliptics as it is popular upstream and dnet is already taken (libdnet).
Oh. When thinking about this: There are naming conflicts. libdnet provides libdnet.so as elliptics does to. What can be done?
First contacting the upstream is better.
Upstream has been contacted, is open about changing the name. No conflict appeard up to now, because the conflicting package libdnet wasn't present.
Hi Fabian, are you still interested in this package? In the meantime, upstream released several updates. Maybe you'd like to update the package, too.
Hi, yes I am. I waited for upstream to change it's name, to solve the naming conflict with libdnet. As this did not happen I'm planning to add a Conflicts tag to the spec.
OK, that's fine. Thanks for the info.
So, I upted the spec ad fixed two problems: - Removed DSO fix (fiexd upstream) - Removed rpath for x86_64 rpmlint just throws a couple of warning about non existant man-pages (see below). SPEC and SRPM: http://fedorapeople.org/~fabiand/elliptics/ Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=2253194 rpmlint: $ rpmlint -v elliptics-* elliptics.i686: I: checking elliptics.i686: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.i686: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.i686: W: no-manual-page-for-binary dnet_fcgi elliptics.i686: W: no-manual-page-for-binary dnet_check_merge elliptics.i686: W: no-manual-page-for-binary dnet_check_create elliptics.i686: W: no-manual-page-for-binary dnet_stat elliptics.i686: W: no-manual-page-for-binary dnet_iotest elliptics.i686: W: no-manual-page-for-binary dnet_check_log elliptics.i686: W: no-manual-page-for-binary dnet_notify elliptics.i686: W: no-manual-page-for-binary dnet_hparser elliptics.i686: W: no-manual-page-for-binary dnet_ioserv elliptics.src: I: checking elliptics.src: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.src: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.src: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.src: I: checking-url http://www.ioremap.net/archive/elliptics/dnet-2.8.0.tar.gz (timeout 10 seconds) elliptics.x86_64: I: checking elliptics.x86_64: W: spelling-error %description -l en_US dnet -> dent, net, diet elliptics.x86_64: W: spelling-error %description -l en_US ioserver -> observer, timeserver, listserver elliptics.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics.x86_64: W: no-manual-page-for-binary dnet_fcgi elliptics.x86_64: W: no-manual-page-for-binary dnet_check_merge elliptics.x86_64: W: no-manual-page-for-binary dnet_check_create elliptics.x86_64: W: no-manual-page-for-binary dnet_stat elliptics.x86_64: W: no-manual-page-for-binary dnet_iotest elliptics.x86_64: W: no-manual-page-for-binary dnet_check_log elliptics.x86_64: W: no-manual-page-for-binary dnet_notify elliptics.x86_64: W: no-manual-page-for-binary dnet_hparser elliptics.x86_64: W: no-manual-page-for-binary dnet_ioserv elliptics-debuginfo.i686: I: checking elliptics-debuginfo.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-debuginfo.x86_64: I: checking elliptics-debuginfo.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.i686: I: checking elliptics-devel.i686: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) elliptics-devel.x86_64: I: checking elliptics-devel.x86_64: I: checking-url http://www.ioremap.net/projects/elliptics/ (timeout 10 seconds) 7 packages and 0 specfiles checked; 0 errors, 24 warnings.
Here are a couple of quick comments: - in the first line, replace %define with %global - according to the source file headers, the license is GPLv2+, not GPLv2 - I suggest to use the default %description for the devel package: The %{name}-devel package contains libraries and header files for developing applications that use %{name}. - remove the duplicate %defattr line in %files devel
Thanks Martin. I applied those changes. Spec and srpm can be found at http://fedorapeople.org/~fabiand/elliptics/ A quick rpmlint on local files just shows the usual warnings. Koji build was also fine.
Hi Fabian, since using Conflicts should be avoided in Fedora packages, I suggest to move the library (and its symlinks) to a subdirectory of %{_libdir}, e.g. %{_libdir}/elliptics/, as long as the conflict persists. In this case, you also have to add a file elliptics-%{_arch}.conf to /etc/ld.so.conf.d containing the directory where the library is located. Nonetheless, it would be much better if upstream renamed the library.
(In reply to comment #12) > Hi Fabian, > > since using Conflicts should be avoided in Fedora packages, I suggest to move > the library (and its symlinks) to a subdirectory of %{_libdir}, e.g. > %{_libdir}/elliptics/, as long as the conflict persists. In this case, you also > have to add a file elliptics-%{_arch}.conf to /etc/ld.so.conf.d containing the > directory where the library is located. > Nonetheless, it would be much better if upstream renamed the library. I hope the library function names don't clash with those in libdnet, since otherwise also this is asking for trouble. Upstream should rename the tarball to 'elliptics'. However, until that happens this review has the wrong name, as per Fedora naming guidelines. The correct package name would be, of course, dnet.
(In reply to comment #13) > I hope the library function names don't clash with those in libdnet, since > otherwise also this is asking for trouble. As far as I see, there are no symbol naming conflicts. > Upstream should rename the tarball to 'elliptics'. However, until that happens > this review has the wrong name, as per Fedora naming guidelines. The correct > package name would be, of course, dnet. If I understand the naming guidelines correctly, the package name could also be elliptics, since it's the name of the project: "When naming a package, the name should match the upstream tarball or project name from which this software came." But maybe I just didn't get the intended meaning. However, I find it pretty strange to call the project "elliptics" and use "dnet" everywhere else. So, dnet is perhaps indeed the better package name.
I'm currently quite bussy at the moment. When I get a bit of time, I will take the points above to resolve the current Conflict with libdnet.
Upstream finally resolved the conflict. I am reopening this ticket.
The only direct URLs to the spec and srpm (in the original comment) are invalid. Please post correct and direct URLs to the spec and srpm. Also, you neglected to unblock FE-DEADREVIEW. I cleared that out for you.
Still no valid spec and srpm links after 10+ months. I'm just going to close this out.